Per discussion at: https://bugs.chromium.org/p/chromium/issues/detail?id=841309#c9 The variations headers appending does not seem to work when network service is enabled, there are no headers added.
juncai@, any update here?
The CL has been sent out for review: https://chromium-review.googlesource.com/c/chromium/src/+/1153947
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e5686301c9e3340281e678500ba27c1bd9992c4 commit 0e5686301c9e3340281e678500ba27c1bd9992c4 Author: Jun Cai <juncai@chromium.org> Date: Thu Aug 09 02:05:33 2018 Network Service: Fix variations appending when network service is enabled This CL adds a |variation_ids_header| to the RendererConfiguration::SetConfiguration() so that the browser can update renderer this information. Bug: 857165 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3c5ac0c7b83a571c0cba9918cf620d895fb2a2c7 Reviewed-on: https://chromium-review.googlesource.com/1153947 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581750} [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/browser/net/variations_http_headers_browsertest.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/browser/profiles/renderer_updater.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/browser/profiles/renderer_updater.h [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/common/google_url_loader_throttle.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/common/google_url_loader_throttle.h [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/common/renderer_configuration.mojom [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/renderer/chrome_render_thread_observer.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/renderer/chrome_render_thread_observer.h [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/chrome/renderer/url_loader_throttle_provider_impl.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/components/variations/net/variations_http_headers.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/components/variations/net/variations_http_headers.h [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/components/variations/net/variations_http_headers_unittest.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/components/variations/variations_http_header_provider.cc [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/components/variations/variations_http_header_provider.h [modify] https://crrev.com/0e5686301c9e3340281e678500ba27c1bd9992c4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Comment 1 by juncai@chromium.org
, Jun 27 2018