New issue
Advanced search Search tips

Issue 857129 link

Starred by 2 users
Status: Assigned
Owner:
olivierrobin@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Re-enable WebStateTest.MessageFromIFrame

Project Member Reported by michaeldo@chromium.org, Jun 27 2018 
Test test stalls and never completes.

I can reproduce this locally when running ios_web_unittests target against iOS 11.4 iPhone 8 simulator. The test never completes when run with all other tests, but succeeded when I ran the test alone.

Error from bot is caused by the test suite timing out:
[ RUN      ] WebStateTest.MessageFromIFrame
[42113:1027:0627/074142.676927:44375901520149:FATAL:wait_util.mm(40)] Check failed: !condition || condition_evaluation_result.

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942559680744992272%2F%2B%2Fsteps%2Fios_web_unittests__iPad_Air_2_iOS_10.3_%2F0%2Fstdout
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c2015e19fff8dd8b1b20ee2408ffe85d6b0570d

commit 0c2015e19fff8dd8b1b20ee2408ffe85d6b0570d
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Wed Jun 27 20:14:06 2018

Disable WebStateTest.MessageFromIFrame test.

TBR=eugenebut@chromium.org

Bug: 857129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909
Reviewed-on: https://chromium-review.googlesource.com/1117300
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570882}
[modify] https://crrev.com/0c2015e19fff8dd8b1b20ee2408ffe85d6b0570d/ios/web/web_state/web_state_unittest.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/185035313c0e02d862b69228738aab7f8ce6f238

commit 185035313c0e02d862b69228738aab7f8ce6f238
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Thu Jun 28 14:07:14 2018

Revert "Disable WebStateTest.MessageFromIFrame test."

This reverts commit 0c2015e19fff8dd8b1b20ee2408ffe85d6b0570d.

Reason for revert: This CL isn't actually disabling the test.

Original change's description:
> Disable WebStateTest.MessageFromIFrame test.
> 
> TBR=eugenebut@chromium.org
> 
> Bug: 857129
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909
> Reviewed-on: https://chromium-review.googlesource.com/1117300
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570882}

TBR=eugenebut@chromium.org,michaeldo@chromium.org

Change-Id: I444e4e1b224685b63cee4f2a672066bfeca8983f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118319
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571105}
[modify] https://crrev.com/185035313c0e02d862b69228738aab7f8ce6f238/ios/web/web_state/web_state_unittest.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02928bf08473f8db3bfd138ccea348ab10580f92

commit 02928bf08473f8db3bfd138ccea348ab10580f92
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Thu Jun 28 16:27:31 2018

Reland "Disable WebStateTest.MessageFromIFrame test."

This is a reland of 0c2015e19fff8dd8b1b20ee2408ffe85d6b0570d

TBR=eugenebut@chromium.org

Original change's description:
> Disable WebStateTest.MessageFromIFrame test.
>
> TBR=eugenebut@chromium.org
>
> Bug: 857129
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909
> Reviewed-on: https://chromium-review.googlesource.com/1117300
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570882}

Bug: 857129
Change-Id: I62a341ccebb1ceef892a2f07eb0faae4d87476d7
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118685
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571159}
[modify] https://crrev.com/02928bf08473f8db3bfd138ccea348ab10580f92/ios/web/web_state/web_state_unittest.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e369ba16b269f719ceb4a060b1374c56de4ecaa

commit 1e369ba16b269f719ceb4a060b1374c56de4ecaa
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Thu Oct 18 15:46:08 2018

Reenable MessageFromIFrame

The iframe support has been developped.
I tested locally and the test passes in the conditions described in
crbug.com/857129
Renable WebStateTest.MessageFromIFrame tentatively.

Bug: 857129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifab8070aa3c70447aa49f6b65ca2010fb5f49573
Reviewed-on: https://chromium-review.googlesource.com/c/1283073
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600774}
[modify] https://crrev.com/1e369ba16b269f719ceb4a060b1374c56de4ecaa/ios/web/web_state/web_state_unittest.mm
►

Sign in to add a comment