New issue
Advanced search Search tips

Issue 857124 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jun 2018
Cc:
amaralp@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Browser crashes on startup with duplex (failed assert)

Project Member Reported by mdjones@chromium.org, Jun 27 2018 
ToolbarControlContainer has an obsolete assert that assumes the menu button will be part of the top toolbar (or the primary control container). This assumption is no longer valid in duplex.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3530d0cb54635b914e49d958471a2adf6e65b6

commit fb3530d0cb54635b914e49d958471a2adf6e65b6
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Jun 28 00:03:46 2018

Remove button existence check in top control container

The overflow menu is no longer necessarily in the top control
container. This patch removes the assert and the handle to the button
in the control container since it isn't actually used.

Bug:  857124 
Change-Id: I6d0d7d913c9743f773a8e1a2b563a38c3d9096d9
Reviewed-on: https://chromium-review.googlesource.com/1117306
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570955}
[modify] https://crrev.com/fb3530d0cb54635b914e49d958471a2adf6e65b6/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java

Comment 2 by mdjones@chromium.org, Jun 28 2018

Status: Fixed (was: Started)
►

Sign in to add a comment