New issue
Advanced search Search tips

Issue 857122 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup Background Fetch internal state when the UI is no longer showing

Project Member Reported by na...@chromium.org, Jun 27 2018

Issue description

We currently maintain some internal state (e.g.: completed_fetches_ inside BackgroundFetchContext) that will not get cleaned up when the user swipes away the notification, or the UI goes away for some other reason.

Add logic to clean it up (potentially in response to the UI no longer being shown).


Shakti, David: any pointers here will be appreciated on ways for us to listen to the or the UI not being shown anymore, or getting dismissed.
 
Is this available issue? I wanna take a look this one.
Hi jdragon, yes this bug is available, although the internal state (completed_fetches_) has moved to BackgroundFetchScheduler. Please feel free to take this on, thanks.
Sorry I missed this!  We should send a download cancelled event when it's dismissed via swipe.  I'm surprised it's not already forwarded.

This is not super straightforward as it's a shared layer across various different clients so the API has to make consistent sense.  In this case, we had decided that transient downloads would act as a user cancel.  For in-progress downloads swiping away shouldn't be possible anyway.

Sign in to add a comment