New issue
Advanced search Search tips

Issue 857121 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

CTS : webkit.WebViewHostSideStartupTest#testStrictMode failure in M68

Project Member Reported by michaelbai@chromium.org, Jun 27 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47262f5240d73f57606389365f499d334a931c0d

commit 47262f5240d73f57606389365f499d334a931c0d
Author: Tao Bai <michaelbai@chromium.org>
Date: Wed Jun 27 23:46:41 2018

Fix CTS webkit.WebViewHostSideStartupTest#testStrictMode

This patch only fix one violation caused by
WebViewChromiumFactoryProvider.initialize()

Bug:  857121 
Change-Id: Ida7d2b3df4e0e7c96f69e42e0b766dde976b2c3a
Reviewed-on: https://chromium-review.googlesource.com/1117268
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570931}
[modify] https://crrev.com/47262f5240d73f57606389365f499d334a931c0d/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Labels: Merge-Rejected-68
Labels: -Pri-3 Pri-1
Labels: -Merge-Rejected-68 Merge-Request-68
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 28 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cmasso@google.com, Jun 28 2018

Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 28 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0814820de71f105f925d6ce2e127109507fdb7eb

commit 0814820de71f105f925d6ce2e127109507fdb7eb
Author: Tao Bai <michaelbai@chromium.org>
Date: Thu Jun 28 04:30:16 2018

Fix CTS webkit.WebViewHostSideStartupTest#testStrictMode

This patch only fix one violation caused by
WebViewChromiumFactoryProvider.initialize()

TBR=michaelbai@chromium.org

(cherry picked from commit 47262f5240d73f57606389365f499d334a931c0d)

Bug:  857121 
Change-Id: Ida7d2b3df4e0e7c96f69e42e0b766dde976b2c3a
Reviewed-on: https://chromium-review.googlesource.com/1117268
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#570931}
Reviewed-on: https://chromium-review.googlesource.com/1117841
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#562}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/0814820de71f105f925d6ce2e127109507fdb7eb/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Status: Fixed (was: Assigned)
Hi.
Could you please tell the version of webview apk that has included with this patch?
Same fail found with 69.0.3497.100.
Thanks.
This landed in 69.0.3475.0. So the failure should not happen in 69.0.3497.100. estellex83@ can you upload a logcat?
Cc: ntfschr@chromium.org
Test log has been uploaded. Please help to check for it.

09-20 04:28:28.850 19858 19858 D StrictMode: StrictMode policy violation; ~duration=78 ms: android.os.strictmode.DiskReadViolation
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1504)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:251)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at java.io.File.exists(File.java:815)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:606)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:597)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.app.ContextImpl.getPreferencesDir(ContextImpl.java:553)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.app.ContextImpl.getSharedPreferencesPath(ContextImpl.java:748)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:401)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:174)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:174)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.preference.PreferenceManager.getDefaultSharedPreferences(PreferenceManager.java:526)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at akb.<clinit>(SourceFile:1)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at org.chromium.components.variations.firstrun.VariationsSeedBridge.markVariationsSeedAsStored(SourceFile:23)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at org.chromium.content.browser.BrowserStartupControllerImpl.nativeFlushStartupTasks(Native Method)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at org.chromium.content.browser.BrowserStartupControllerImpl.a(SourceFile:50)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at afP.run(Unknown Source:36)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at org.chromium.base.ThreadUtils.a(SourceFile:10)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at xf.b(SourceFile:107)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at xf.b(SourceFile:172)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at xf.a(SourceFile:153)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at com.android.webview.chromium.WebViewChromiumFactoryProvider.a(SourceFile:231)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at com.android.webview.chromium.WebViewChromium.init(SourceFile:44)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.webkit.WebView.<init>(WebView.java:678)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.webkit.WebView.<init>(WebView.java:604)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.webkit.WebView.<init>(WebView.java:587)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.webkit.WebView.<init>(WebView.java:574)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at android.webkit.WebView.<init>(WebView.java:564)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at com.android.cts.webkit.WebViewStartupCtsActivity.createAndAttachWebView(WebViewStartupCtsActivity.java:33)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at com.android.cts.webkit.WebViewDeviceSideStartupTest.createWebViewAndNavigate(WebViewDeviceSideStartupTest.java:198)
09-20 04:28:28.850 19858 19858 D StrictMode: 	at com.android.cts.webkit.WebViewDeviceSideStartupTest.testStrictModeNotViolatedOnStartup(WebViewDeviceSideStartupTest.java:183)

Thanks.
device_logcat_test.zip
187 KB Download
Cc: michaelbai@chromium.org
Owner: paulmiller@chromium.org
Status: Unconfirmed (was: Fixed)
Paul can you look at this? If this is a new issue, can you file a bug and re-close this?
Status: Assigned (was: Unconfirmed)
Owner: michaelbai@chromium.org
Status: Fixed (was: Assigned)
This is a separate bug. Filed  https://crbug.com/889241 .
Thanks, Paul! And thanks estellex83@gmail.com for reporting this.

Sign in to add a comment