Media Controls: Clean up unnecessary sizing-* CSS code |
||
Issue descriptionWith new spec updates, the sizing-large CSS class becomes unnecessary since it has no differences from the sizing-medium class. Also, there are some rules where there are now no differences between sizes at all (scrubber size, overflow menu) and those should be cleaned up to not depend on the sizing-* class
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ec49703d6111ddb3893f32d66478c58e426b885 commit 4ec49703d6111ddb3893f32d66478c58e426b885 Author: Jazz Xu <jazzhsu@google.com> Date: Thu Oct 18 21:10:19 2018 [Media Controls] Clean up sizing class. Remove all sizing-large classes. Bug: 857120 Change-Id: I8e3f9f3ca0061f03f2f28388d13936c24371828f Reviewed-on: https://chromium-review.googlesource.com/c/1287297 Commit-Queue: Jazz Xu <jazzhsu@google.com> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600908} [modify] https://crrev.com/4ec49703d6111ddb3893f32d66478c58e426b885/third_party/WebKit/LayoutTests/media/controls/resizing-changes-css-class.html [modify] https://crrev.com/4ec49703d6111ddb3893f32d66478c58e426b885/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/4ec49703d6111ddb3893f32d66478c58e426b885/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
,
Oct 18
|
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Jun 27 2018