New issue
Advanced search Search tips

Issue 857110 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS , Mac
Pri: 3
Type: Bug

Blocking:
issue 855791



Sign in to add a comment

ios waterfall build failed when trying to land cipd gn package

Project Member Reported by scottmg@chromium.org, Jun 27 2018

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device/95948

bot_update I think didn't pull it https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942550096692057824%2F%2B%2Fsteps%2Fbot_update%2F0%2Fstdout but I'm not sure why.

then of course mb fails later:

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942550096692057824%2F%2B%2Fsteps%2Fgenerate_build_files__mb_%2F0%2Fstdout

""" to /b/s/w/ir/cache/builder/src/out/Release-iphoneos/args.gn.
/b/s/w/ir/cache/builder/src/third_party/gn/gn gen //out/Release-iphoneos --check
Traceback (most recent call last):
  File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 63, in Main
    ret = self.args.func()
  File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 300, in CmdGen
    return self.RunGNGen(vals)
  File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 778, in RunGNGen
    ret, _, _ = self.Run(cmd)
  File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1302, in Run
    ret, out, err = self.Call(cmd, env=env, buffer_output=buffer_output)
  File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1316, in Call
    env=env)
  File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 390, in __init__
    errread, errwrite)
  File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 1025, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

which seems reasonable.

John is it obvious to you what might be wrong in pulling the gn cipd package here?
 
Hmm, I thought the error near the end was relevant "WARNING: Couldn't match revinfo line", but I think that's not actually fatal (possibly just that gclient revinfo doesn't understand $platform so it can't display current versions somewhere).

But the output otherwise looks the same as all the other platforms/configs that worked fine. So perhaps something unrelated... possibly  bug 794764 ?
Cc: dpranke@chromium.org vadimsh@chromium.org
Aha! Every other bot in https://chromium-review.googlesource.com/c/chromium/src/+/1117264/4 starts the recipe with "remove .cipd". The ios- ones however, do not. So I'm thinking this seems likely to be related to  https://crbug.com/794764 .

Anyone know if there's a reason why ios is different?
ugh, the ios recipes are different in so many ways.

we need to do something like https://chromium.googlesource.com/chromium/tools/build/+/ba55b88ad560966554ee82224eec00e1d9daa5b3 for ios.
(the why basically boils down to "historical reasons," and resolving those is on our longer term to-do list.)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ce027be4609c3fe99f3040c62eb7f6783be813ae

commit ce027be4609c3fe99f3040c62eb7f6783be813ae
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 27 18:58:00 2018

Add 'remove .cipd' step to ios builders

This is the same as
https://chromium.googlesource.com/chromium/tools/build/+/ba55b88ad560966554ee82224eec00e1d9daa5b3,
but ios isn't handled in the same code path.

Bug:  794764 ,  849374 ,  857110 
Change-Id: Ib4c60fffc975b04ef7907112095209c4d79c00cf
Reviewed-on: https://chromium-review.googlesource.com/1117359
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/explain.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_compilation_failure.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/timed_out.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/errors.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_build.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/icu_patch.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/target_cpu_missing.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/is_debug_missing.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/unified_builder_tester.expected/basic_experimental.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/patch_failure.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/goma_compilation_failure.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/deprecate_xcode_version.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/parent.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_canary.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/fyi.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_checkout.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/perf_test.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/README.recipes.md
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/no_tests.json
[modify] https://crrev.com/ce027be4609c3fe99f3040c62eb7f6783be813ae/scripts/slave/recipes/ios/try.expected/no_compilation.json

Status: Fixed (was: Started)
That seems to have fixed the ios tryjobs in https://chromium-review.googlesource.com/c/chromium/src/+/1117264.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fed0e8ec393c317037a824b63b3e9690b8b0a4fc

commit fed0e8ec393c317037a824b63b3e9690b8b0a4fc
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 28 05:02:14 2018

Pull GN via CIPD package

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1112840.


The gn binary will be downloaded into third_party/gn. This CL rolls
buildtools forward to a revision where the gn binary is a stub that
prints an error message and returns 1. This is to avoid depending
on the old location, and helping users relying on gn auto regen.

Update mb.py to use the new location.

Update explicit location in ios/web_view/BUILD.gn for the new location.

Update explicit location in
tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new
location.

Update explicit location in tools/licenses.py with for the new location.

Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py.

Bug: 855791
Bug: 856883
Bug:  856884 
Bug: 856878
Bug:  856899 
Bug: 857107
Bug:  857110 
Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1117264
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571031}
[modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/DEPS
[modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/ios/web_view/BUILD.gn
[modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/testing/libfuzzer/gen_fuzzer_owners.py
[modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/licenses.py
[modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/mb/mb.py
[modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/mb/mb_unittest.py
[modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8962649114490c145c5cba76fe290752014d6432

commit 8962649114490c145c5cba76fe290752014d6432
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Thu Jun 28 17:07:46 2018

Revert "Pull GN via CIPD package"

This reverts commit fed0e8ec393c317037a824b63b3e9690b8b0a4fc.

Reason for revert: It broke most of the chrome_informational builders at BuildPackages stage. See  crbug.com/857133  for details. 

Original change's description:
> Pull GN via CIPD package
> 
> This is a reland of
> https://chromium-review.googlesource.com/c/chromium/src/+/1112840.
> 
> 
> The gn binary will be downloaded into third_party/gn. This CL rolls
> buildtools forward to a revision where the gn binary is a stub that
> prints an error message and returns 1. This is to avoid depending
> on the old location, and helping users relying on gn auto regen.
> 
> Update mb.py to use the new location.
> 
> Update explicit location in ios/web_view/BUILD.gn for the new location.
> 
> Update explicit location in
> tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new
> location.
> 
> Update explicit location in tools/licenses.py with for the new location.
> 
> Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py.
> 
> Bug: 855791
> Bug: 856883
> Bug:  856884 
> Bug: 856878
> Bug:  856899 
> Bug: 857107
> Bug:  857110 
> Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/1117264
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571031}

TBR=dpranke@chromium.org,scottmg@chromium.org

Change-Id: I28962c879b7bc24e809b29427122bb425e9450a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855791, 856883,  856884 , 856878,  856899 , 857107,  857110 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118825
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571170}
[modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/DEPS
[modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/ios/web_view/BUILD.gn
[modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/testing/libfuzzer/gen_fuzzer_owners.py
[modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/licenses.py
[modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/mb/mb.py
[modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/mb/mb_unittest.py
[modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc

Sign in to add a comment