oopash: SessionController should know if a user is the device owner |
|||
Issue descriptionSee TODO in https://cs.chromium.org/chromium/src/ash/session/session_controller.cc?sq=package:chromium&g=0&l=573 Maybe it should go in ash.mojom.UserInfo https://cs.chromium.org/chromium/src/ash/session/session_controller.cc?sq=package:chromium&g=0&l=573 If we had this we could move tap-to-click preferences from chrome to ash, see https://chromium-review.googlesource.com/c/chromium/src/+/1116210 (mukai, this could be a good first bug.)
,
Jun 28 2018
Owner account id is set asynchronously after policy blob signature check here [1]. [1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc?rcl=1fc649b601a08b37baaf3b557d2ec14d3b1445f1&l=760
,
Jun 29 2018
,
Jul 4
Question: does session controller really want to distinguish the device owner from a regular user? As far as I can see, nothing is different among regular users and the device owner within ash; only two files refer to LoginStatus::OWNER (tray_user and shelf_context_menu_model), but their code falls into the same code path for a normal user. Possibly we could just remove LoginStatus::OWNER, if that's the case.
,
Jul 9
Hmm. I'm not sure. I think there was some code in //chrome that we wanted to move to //ash that required knowledge of OWNER. Long-term I think we want to eliminate ash::LoginStatus entirely. There are lots of different "login state" enums, including chromeos::LoginState, session_manager::SessionState, user_manager::UserType, etc.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/866203ad67e802a05e38d52a0e3ce4527d5001da commit 866203ad67e802a05e38d52a0e3ce4527d5001da Author: Jun Mukai <mukai@chromium.org> Date: Tue Jul 24 18:50:55 2018 propagate the device owner info to ash::SessionController BUG= 857103 TEST=ash_unittests, unit_tests Change-Id: I46f1b09a2d2ad4a90fe42c75a9d0f587c03ab1cf Reviewed-on: https://chromium-review.googlesource.com/1137232 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#577626} [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/ash/public/interfaces/user_info.mojom [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/ash/session/session_controller.cc [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/ash/session/session_controller_unittest.cc [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/ui/ash/session_controller_client.cc [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/ui/ash/session_controller_client.h [modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/ui/ash/session_controller_client_unittest.cc
,
Jul 24
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted