New issue
Advanced search Search tips

Issue 857103 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

oopash: SessionController should know if a user is the device owner

Project Member Reported by jamescook@chromium.org, Jun 27 2018

Issue description

Comment 1 Deleted

Comment 3 by mukai@chromium.org, Jun 29 2018

Owner: mukai@chromium.org
Status: Assigned (was: Untriaged)
Question: does session controller really want to distinguish the device owner from a regular user? As far as I can see, nothing is different among regular users and the device owner within ash; only two files refer to LoginStatus::OWNER (tray_user and shelf_context_menu_model), but their code falls into the same code path for a normal user.

Possibly we could just remove LoginStatus::OWNER, if that's the case.
Hmm. I'm not sure. I think there was some code in //chrome that we wanted to move to //ash that required knowledge of OWNER.

Long-term I think we want to eliminate ash::LoginStatus entirely. There are lots of different "login state" enums, including chromeos::LoginState, session_manager::SessionState, user_manager::UserType, etc.

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/866203ad67e802a05e38d52a0e3ce4527d5001da

commit 866203ad67e802a05e38d52a0e3ce4527d5001da
Author: Jun Mukai <mukai@chromium.org>
Date: Tue Jul 24 18:50:55 2018

propagate the device owner info to ash::SessionController

BUG= 857103 
TEST=ash_unittests, unit_tests

Change-Id: I46f1b09a2d2ad4a90fe42c75a9d0f587c03ab1cf
Reviewed-on: https://chromium-review.googlesource.com/1137232
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577626}
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/ash/public/interfaces/user_info.mojom
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/ash/session/session_controller.cc
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/ash/session/session_controller_unittest.cc
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/866203ad67e802a05e38d52a0e3ce4527d5001da/chrome/browser/ui/ash/session_controller_client_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment