New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857095 link

Starred by 1 user
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Jul 2
Cc:
hiroh@chromium.org
dcasta...@chromium.org
mcasas@chromium.org
tfiga@chromium.org
█ hoegsberg@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-07-11
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 822346



Sign in to add a comment

teach minigbm to understand BO_USE_HW_VIDEO_DECODER in non-x86 platforms

Project Member Reported by mcasas@chromium.org, Jun 27 2018 
BO_USE_HW_VIDEO_DECODER is understood in i915 [1] but it made
ARM unhappy (which cause the revert in  crrev.com/c/1116738).
Teach that/those platform(s) to essentially do nothing if the
flag comes along.


[1] https://cs.corp.google.com/search/?q=BO_USE_HW_VIDEO_DECODER+package:%5Echromeos_public$&type=cs
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/minigbm/+/dea0ccbaac1602e0453b79ee6c66785012b00048

commit dea0ccbaac1602e0453b79ee6c66785012b00048
Author: Miguel Casas <mcasas@chromium.org>
Date: Mon Jul 02 22:32:45 2018

minigbm: Add BO_USE_HW_VIDEO_DECODER to supported flags

This CL adds BO_USE_HW_VIDEO_DECODER to the potential list of flags
supported by RockChip, AMD and MediaTek for formats that can be used
for video playback -or- for protected buffer allocation.

Change-Id: Ib617a4138ecdf2fa00900aacd8afb412f77f78d5
BUG= chromium:857095 
TEST=compiled minigbm for the said platforms.
Reviewed-on: https://chromium-review.googlesource.com/1117606
Commit-Ready: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>

[modify] https://crrev.com/dea0ccbaac1602e0453b79ee6c66785012b00048/amdgpu.c
[modify] https://crrev.com/dea0ccbaac1602e0453b79ee6c66785012b00048/rockchip.c
[modify] https://crrev.com/dea0ccbaac1602e0453b79ee6c66785012b00048/mediatek.c

Comment 2 by mcasas@chromium.org, Jul 2

Owner: mcasas@chromium.org
Status: Fixed (was: Available)
Tentatively fixed.

Comment 3 by mcasas@chromium.org, Jul 2

Blocking: 822346
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cb7337ead74107f32239e0d8386ada3355ce9c1

commit 1cb7337ead74107f32239e0d8386ada3355ce9c1
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Jul 03 00:31:48 2018

Reland: Ozone DRM: use GBM_BO_USE_HW_VIDEO_DECODER

The original CL was reverted because BO_USE_HW_VIDEO_DECODER is not
correctly handled in ARM platforms _for protected buffers_ (i.e.
allocations coming from ARC++). crrev.com/c/1117606 added support
for the flag on those platforms.

CQ-DEPEND:1117025
TBR=dcastagna@chromium.org (no changes)

Original CL -----------------------------------------------------------
This CL adds the GBM_BO_USE_HW_VIDEO_DECODER flag to
gfx::BufferUsage::SCANOUT_VDA_WRITE buffers. It's a spinoff of a
comment [1] in crrev.com/c/1021675.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1021675/18/ui/ozone/platform/drm/gpu/drm_thread.cc#147

Bug: 822346,  857095 
Test: simplechrome video playback on nautilus, vaapi engaged.
Change-Id: I1c11a8fffa662b69049d121ccb48ebfd85097228
Reviewed-on: https://chromium-review.googlesource.com/1104394
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1117025
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572053}
[modify] https://crrev.com/1cb7337ead74107f32239e0d8386ada3355ce9c1/ui/ozone/platform/drm/gpu/drm_thread.cc

Comment 5 by mcasas@chromium.org, Jul 3

Labels: Needs-Verification
NextAction: 2018-07-11

Comment 6 by sahel@chromium.org, Jul 4 

Trying to build chromium ToT for chromeOS fails with this error:
../../ui/ozone/platform/drm/gpu/drm_thread.cc:149:15: error: use of undeclared identifier 'GBM_BO_USE_HW_VIDEO_DECODER'
              GBM_BO_USE_HW_VIDEO_DECODER

Is it related to this bug?

Comment 7 by dcasta...@chromium.org, Jul 4 

You might need to get a newer cros-sdk if you're using simple chrome workflow.

Comment 8 by monor...@bugs.chromium.org, Jul 11 

The NextAction date has arrived: 2018-07-11
►

Sign in to add a comment