New issue
Advanced search Search tips

Issue 857068 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Raised omnibox top-align is off

Project Member Reported by bklmn@chromium.org, Jun 27 2018

Issue description

Chrome Version: 67.0.3396.87
OS: MacOS 10.13.4 

What is the expected result?
Omnibox in raised state to top-align with top of toolbar

What happens instead?
Omnibox in raised state is sitting 1px above the toolbar

 

Comment 1 by bklmn@chromium.org, Jun 27 2018

857068.png
543 KB View Download

Comment 2 by bklmn@chromium.org, Jun 27 2018

Cc: bklmn@chromium.org
Owner: manukh@chromium.org
Status: Assigned (was: Untriaged)
manukh: Do you mind investigating this one?
Labels: -Pri-3 Pri-1
this should be landed before we start UI implementation review, so moving to P1.

Comment 5 by manukh@chromium.org, Jun 27 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05888f47880ec060bcef689feeb1228ab9be31a4

commit 05888f47880ec060bcef689feeb1228ab9be31a4
Author: manuk <manukh@chromium.org>
Date: Thu Jun 28 14:01:05 2018

Omnibox UI Refresh: align top of raised omnibox with top of location bar

Decreased top inset from 5 to 4 px. With 5 px, the top of the omnibox was 1 pixel higher than the top of the location bar.

Bug:  857068 
Change-Id: Id1ea4601aed65f62fffccd05deac5dcbeab8d0d5
Reviewed-on: https://chromium-review.googlesource.com/1117642
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571104}
[modify] https://crrev.com/05888f47880ec060bcef689feeb1228ab9be31a4/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc

Labels: TE-Verified-69.0.3476.0 TE-Verified-M69
Able to reproduce the issue on chrome reported version 69.0.3474.0(build without fix)
Verified the fix on Mac 10.12.6 on Chrome version #69.0.3476.0 as per the comment#0
Attached screenshot for reference.
Observed "Omnibox in raised state to top-align with top of toolbar"
Hence, the fix is working as expected.
Adding the verified label.

Note: Able to reproduce the issue on Windows-10 & Ubuntu 14.04, verified the fix and it is working as intended.

Thanks!
857068.png
114 KB View Download

Comment 8 by manukh@chromium.org, Jun 29 2018

Status: Verified (was: Started)

Sign in to add a comment