Issue metadata
Sign in to add a comment
|
Regression: Vertical Scroll bar is missing in chrome://downloads/ page
Reported by
khushal....@etouch.net,
Jun 27 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3474.0 (Official Build)07ea11a69a583156cf0601a4a2f6253b84689574-refs/branch-heads/3474@{#1} (64-bit) OS: Mac 10.13.6 (Touch Bar) Pre-condition: Download few files (at least 20) such that we need to scroll up/down download entries in chrome://downloads/ page. Steps to reproduce: (1) Launch chrome and navigate to chrome://downloads/ page containing downloaded files. (2) Now try to scroll up/down the chrome://downloads/ page and Observe. Actual Result: Vertical Scroll bar is missing in chrome://downloads/ page. Expected Result: Vertical Scroll bar should be present in chrome://downloads/ page. This is a Regression issue broken in 'M-69' and providing the bisect info below: Good Build: 69.0.3457.0 (Revision: 566679) Bad Build: 69.0.3460.0 (Revision: 567312) You are probably looking for a change made after 567156 (known good), but no later than 567157 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/778900a4e3a018e21fef2be6811aae1c0277c629..2551aadf9bfc411f9f11e3894c4a5e7673da71a6 Suspect: https://chromium.googlesource.com/chromium/src/+/2551aadf9bfc411f9f11e3894c4a5e7673da71a6 @chrishtr: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also seen on M-69 Dev (build #69.0.3472.3). Kindly refer attached screen cast. Thank You..!!
,
Jul 3
Issue 859838 has been merged into this issue.
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/496307f84f8edf8fd2c11cf3e36854ed77c4632a commit 496307f84f8edf8fd2c11cf3e36854ed77c4632a Author: Chris Harrelson <chrishtr@chromium.org> Date: Wed Jul 11 20:48:48 2018 Adjust overlay scrollbar reparenting trigger logic - Determine non-stacked-with-in-flow-stacked descendants scrollers, and use that information to decide when to reparent overlay scrollbars. Delete old logic. - Implement this new bit in the descendant-dependent PaintLayer tree walk. Move the has-self-painting- layer-descendant bit to that tree walk also. Overlay scrollbars for an overflow scrolling element need to paint after all content that scrolls under it. If the element is stacked, this is easy because we can iterate over all PaintLayers that scroll with it (including the element) and reparent the overlay scrollbars after that in the GraphicsLayer list of the parent stacking context. If the element is not stacked, however, this is trickier, as we should only reparent if there is a stacked scrolling PaintLayer under the element, because the element is not painted in the containing stacking context, but instead by its direct ancestor, which may not be a stacking context. scrollbars/overlay-scrollbars-within-overflow-scroll.html is a good example of this, where the inner scroller is not stacked and has no stacked descendant. Detecting non-stacked with stacking, scrolled descendants allow us to simplify the logic for determining reparenting triggers, to avoid complicated/potentially slow logic in CompositingInputsUpdater. To make room for the new bit, merge the HasSelfPaintingLayerDescendant bit into the descendant-dependent tree walk. This bit was computed in its own tree walk with its own dirty bit, which was unnecessarily complicated and slow. Bug: 857035 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idcf8fdf0ab20ca25edc9e5ff33c203efee392dbd Reviewed-on: https://chromium-review.googlesource.com/1128333 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#574324} [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned-expected.png [add] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned-expected.txt [add] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned.html [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_builder.cc [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/paint_layer.cc [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/paint_layer.h [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h [modify] https://crrev.com/496307f84f8edf8fd2c11cf3e36854ed77c4632a/third_party/blink/renderer/core/paint/paint_layer_test.cc
,
Jul 13
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by chrishtr@chromium.org
, Jun 28 2018