New issue
Advanced search Search tips

Issue 857021 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-12
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 850372



Sign in to add a comment

[Cros] GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons is flaky in release & debug

Project Member Reported by noel@chromium.org, Jun 27 2018

Issue description

GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons browser tests (with patch) is flaking on the CQ linux-chromeos-rel bot.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=GalleryBrowserTest



 

Comment 1 by noel@chromium.org, Jun 27 2018

GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons.png
169 KB View Download

Comment 2 by noel@chromium.org, Jun 27 2018

Capturing a log.
GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons.txt
9.1 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc051bdb41c4f6891e22bc08d25b9b0de9a2a87

commit 7fc051bdb41c4f6891e22bc08d25b9b0de9a2a87
Author: Noel Gordon <noel@chromium.org>
Date: Wed Jun 27 13:01:46 2018

Disable GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons

Flakes in RELEASE on linux-chromeos-rel CQ bot.

Tbr: tapted
Bug:  850372 , 857021 
Change-Id: I548307fa8a93689a348f2e96504815e3fe27cf44
Reviewed-on: https://chromium-review.googlesource.com/1116879
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570745}
[modify] https://crrev.com/7fc051bdb41c4f6891e22bc08d25b9b0de9a2a87/chrome/browser/chromeos/file_manager/gallery_browsertest.cc

Comment 5 by noel@chromium.org, Jun 27 2018

Status: Fixed (was: Started)

Comment 6 by noel@chromium.org, Jun 27 2018

Blocking: 850372
It had started failing on the DEBUG tree bot too.
e.g. build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6516

Comment 8 by noel@chromium.org, Jun 29 2018

Thanks Peter.  Captured the DEBUG log from build 6516 (they are not perma-links, they eventually disappear, but sure help to resolve issues like this).
GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons.DEBUG.log.txt
43.6 KB View Download

Comment 9 by noel@chromium.org, Jun 29 2018

Summary: [Cros] GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons is flaky in release & debug (was: [Cros] GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons is flaky in release)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71543c0aa5d6efe0926a26cf17fba325cd58f87d

commit 71543c0aa5d6efe0926a26cf17fba325cd58f87d
Author: Trent Apted <tapted@chromium.org>
Date: Wed Jul 04 07:07:29 2018

Deflake GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons.

Although it doesn't flake in Release, the presense of DCHECKs makes
this test fail. Waiting just for the gallery element could read the
button state in the static gallery.html DOM, so wait for the first image
to be fully loaded.

Bug:  857021 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4e07384b105489410a73894b4a9e0a58bdae287d
Reviewed-on: https://chromium-review.googlesource.com/1125589
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572500}
[modify] https://crrev.com/71543c0aa5d6efe0926a26cf17fba325cd58f87d/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
[modify] https://crrev.com/71543c0aa5d6efe0926a26cf17fba325cd58f87d/ui/file_manager/integration_tests/gallery/slide_mode.js

Cc: -tapted@chromium.org noel@chromium.org
Owner: tapted@chromium.org
Status: Started (was: Fixed)
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons
Labels: -Pri-1 Pri-2
NextAction: 2018-07-12
Nice and green so far :)
Screenshot from 2018-07-05 09-21-07.png
27.6 KB View Download
Yeap, looking good!  We can move on.  We can look again on the next-action date, and close this bug out.   Thanks for fixing, Trent. 
Looks well fixed to me.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CheckAvailabilityOfEditAndPrintButtons
Screen Shot 2018-07-10 at 10.22.47 AM.png
148 KB View Download
Status: Fixed (was: Started)
The NextAction date has arrived: 2018-07-12
Status: Verified (was: Fixed)

Sign in to add a comment