New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857020 link

Starred by 1 user
Status: WontFix
Owner:
yhanada@chromium.org
Closed: Jul 19
Cc:
xiy...@chromium.org
penghuang@chromium.org
█ reve...@chromium.org
sky@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Why is //ash/wayland separated from //ash?

Project Member Reported by yhanada@chromium.org, Jun 27 2018 
Spun off from crrev.com/c/1109451 .

//ash/wayland and //ash/system/message_center/arc seems to be separated from //ash target intentionally.
I added similar build target //ash/keyboard/arc in the CL, but not sure why they are needed to be separated from //ash.

Can we merge these build targets into //ash?

Comment 1 by xiy...@chromium.org, Jun 27 2018 

I am not sure why //ash/wayland is in its own target. But if it gets merged into //ash, we could merge //ash/system/message_center/arc to //ash too. The arc notification code stays in its own target, because it provides notification surface impl/manager and //ash/wayland depends on that.

Comment 2 by yhanada@chromium.org, Jul 2

Components: UI>Shell Platform>Apps>ARC

Comment 3 by yhanada@chromium.org, Jul 2 

//ash/wayland is used only from /ash, so it should be ok to merge it into //ash.
I'll create a CL soon.

Comment 4 by sky@chromium.org, Jul 9 

Smaller build targets can often make for more manageable code. I believe with ash/wayland the hope is that it doesn't have deps on ash, so it can be it's own target.

Comment 5 by yhanada@chromium.org, Jul 19

Status: WontFix (was: Assigned)
I see. so I won't merge the targets.
►

Sign in to add a comment