New issue
Advanced search Search tips

Issue 857017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Security



Sign in to add a comment

CVE-2018-11412 CrOS: Vulnerability reported in Linux kernel

Project Member Reported by vomit.go...@appspot.gserviceaccount.com, Jun 27 2018

Issue description

VOMIT (go/vomit) has received an external vulnerability report for the Linux kernel. 

Advisory: CVE-2018-11412
  Details: http://vomit.googleplex.com/advisory?id=CVE/CVE-2018-11412
  CVSS severity score: 4.3/10.0
  Description:

In the Linux kernel 4.13 through 4.16.11, ext4_read_inline_data() in fs/ext4/inline.c performs a memcpy with an untrusted length value in certain circumstances involving a crafted filesystem that stores the system.data extended attribute value in a dedicated inode.



This bug was filed by http://go/vomit
Please contact us at vomit-team@google.com if you need any assistance.

 

Comment 1 by groeck@chromium.org, Jun 27 2018

Cc: wonderfly@google.com zsm@chromium.org
Labels: M-68 Security_Severity-Medium Security_Impact-Stable Pri-1
Owner: groeck@chromium.org
Status: Started (was: Untriaged)
Fixed with upstream commit 117166efb1ee8f13 ("ext4: do not allow external inodes for inline data"). Per CVE, only chromeos-4.14 is affected. Fix is queued for inclusion into chromeos-4.14 with the merge of v4.14.52. Will cherry-pick into beta release after the merge is complete.

Cc: rkolchmeyer@google.com

Comment 3 by groeck@chromium.org, Jun 29 2018

Labels: Merge-Request-68
Merge request is for the merge of upstream commit 117166efb1ee8f13 into chromeos-4.14.

Project Member

Comment 4 by sheriffbot@chromium.org, Jun 29 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 29 2018

Labels: merge-merged-release-R68-10718.B-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/52a84cab3bb49e459a20306dd35707a880d7a1bc

commit 52a84cab3bb49e459a20306dd35707a880d7a1bc
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jun 29 18:44:41 2018

UPSTREAM: ext4: do not allow external inodes for inline data

commit 117166efb1ee8f13c38f9e96b258f16d4923f888 upstream.

The inline data feature was implemented before we added support for
external inodes for xattrs.  It makes no sense to support that
combination, but the problem is that there are a number of extended
attribute checks that are skipped if e_value_inum is non-zero.

Unfortunately, the inline data code is completely e_value_inum
unaware, and attempts to interpret the xattr fields as if it were an
inline xattr --- at which point, Hilarty Ensues.

This addresses CVE-2018-11412.

https://bugzilla.kernel.org/show_bug.cgi?id=199803

BUG= chromium:857017 
TEST=Run image through ext4 file system tests

Change-Id: I65d201d0ba3a03ce5ff98bfe45d394c857f82cac
Reported-by: Jann Horn <jannh@google.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Fixes: e50e5129f384 ("ext4: xattr-in-inode support")
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-on: https://chromium-review.googlesource.com/1120875
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Commit-Queue: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/52a84cab3bb49e459a20306dd35707a880d7a1bc/fs/ext4/inline.c

Comment 7 by groeck@chromium.org, Jun 29 2018

Status: Fixed (was: Started)
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 30 2018

Labels: Restrict-View-SecurityNotify
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 3

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-68
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 6

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment