Issue metadata
Sign in to add a comment
|
Regression: Gap doesn't seen between Maximize and Minimize buttons of Chrome.
Reported by
dchau...@etouch.net,
Jun 27 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3440.42 (Official Build) Revision 1e775812933cd8759b2ac69a967b17767d3063bd-refs/branch-heads/3440@{#544} 32/64-bit. OS: Windows-10. Pre-condition: Enable 'Force UI Direction' to 'Right-to-left' from chrome://flags URL: https://chrome.google.com/webstore/detail/sunset/oglpppdfhoddodgobkgdocdonaifnpde What steps will reproduce the problem? 1. Launch Chrome, go to above URL and add the 'Sunset' or any dark theme. 2. Once theme is applied, observe the Maximize and Minimize button of browser at top left corner. Actual: Gap doesn't seen between Maximize and Minimize button. Expected: Gap should be seen between Maximize and Minimize button. This is a Win-10 specific regression issue, broken in M-67 series, below is manual regression range. Good build: 67.0.3386.0 (Revision: 547396) Bad build: 67.0.3387.0 (Revision: 547597) Unable to provide the bisect using has-bisect-per-revision script, hence providing the bisect using Chromium bisect script: You are probably looking for a change made after 547578 (known good), but no later than 547587 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/98af1b5696ccac71d4b141d1a0d25dc9f73091f7..9741ff8ea55767f220ab17dafbb5f7c01b2ace41 Suspecting: https://chromium.googlesource.com/chromium/src/+/cce37ea23cb1e16bd129e5da36c960c5ab6012b8 @bsep: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. This issue is also reproducible on Stable #67.0.3396.99, Beta #68.0.3440.33 and Canary #69.0.3474.0 2. This issue is not seen on Windows(7,8,8.1), Mac(10.12.6 , 10.13.1 , 10.13.5, 10.13.6) and Linux(14.04) machines. Kindly review the attached screen-cast for reference. Thank you
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/196fad80c3a3e9209b5be79b8ed349b3cf7c625b commit 196fad80c3a3e9209b5be79b8ed349b3cf7c625b Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Jun 28 00:47:16 2018 Fix Windows caption button spacing in RTL languages. We increase the caption button size and inset the painting slightly to give visual space between them without creating an unclickable dead pixel. But the bounds inset operation always insets the same side regardless of language direction, so this patch changes which button is "last" to avoid the gaps being on the wrong side. Bug: 857007 Change-Id: Ibec7863264cf8efa6cc4ede822a1ae36963c7e93 Reviewed-on: https://chromium-review.googlesource.com/1117742 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570983} [modify] https://crrev.com/196fad80c3a3e9209b5be79b8ed349b3cf7c625b/chrome/browser/ui/views/frame/windows_10_caption_button.cc
,
Jun 28 2018
,
Jun 28 2018
Update:- Re-tested this issue on Windows-10 machines using latest Chrome latest Canary build# 69.0.3475.0 and fix is working as expected.. Hence adding TE-Verified labels. Please find the attached screen-cast for reference. Thanks..! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bsep@chromium.org
, Jun 27 2018