New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856994 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Tab Focus is seen missing on 'Browse' option immediately after focus is on 'Model' option in 'Select a printer manufacturer and model' overlay of Printers page

Project Member Reported by mmanchala@chromium.org, Jun 27 2018

Issue description

Chrome Version: 68.0.3440.40/10718.34.0 Beta-channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings page-> At 'Printing' click on 'Printers
(2)Now in 'Add a printer manually' overlay add any Printer(add Name),Address -> click on 'ADD' button -> now 'Select a printer manufacturer and model' overlay ,press 'Tab' button until focus is on 'Model' option
(3)Again press 'Tab' button and observe Focus is not seen anywhere and now again press 'Tab' button -> Observe focus is on 'Browse' option
(Please refer Video) 

Expected: After Focus is on 'Model' option and on pressing 'Tab' Focus should be seen on 'Browse' option
Actual: Instead After 'Model' option Focus is seen missing on 'Browse' option and on again pressing 'Tab' focus is seen

This is Non-Regression Issue seen as 'Printers' option is introduced from M-59
 
Actual_TabFocus.mp4
16.6 MB Download
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8197e7d9b6d7a5c5f766dafb53feeee60c28ea2a

commit 8197e7d9b6d7a5c5f766dafb53feeee60c28ea2a
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Jun 29 20:10:40 2018

Settings: fix cups-printer dialog tab order.

Changing tabindex=-1 for a readonly field that is not intended to be
focused. Screen-readers can still navigate to it, so it will still read
the value if there's any. This essentially turns the input into a <div>
that may contain text, except you can drag to the right to see more text
if the value is very long and overflows.

Bug: 856994
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id210c48c7b63182bd6369d5bc1c87c72742cb193
Reviewed-on: https://chromium-review.googlesource.com/1117310
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571604}
[modify] https://crrev.com/8197e7d9b6d7a5c5f766dafb53feeee60c28ea2a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/8197e7d9b6d7a5c5f766dafb53feeee60c28ea2a/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html

Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.

Sign in to add a comment