New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 856984 link

Starred by 2 users
Status: Fixed
Owner:
chenghan@chromium.org
Closed: Jul 21
Cc:
█ yhong@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add an argument in battery_current pytest to use max voltage

Project Member Reported by chenghan@chromium.org, Jun 27 2018 
Chrome Version: ToT
OS: ChromeOS

In battery_current pytest, it checks the charger voltage from the command `ectool usbpdpower`. Sometimes the reported voltage is 0mV, which can be caused by hardware not supporting it (b/74096395).

It is better to add an argument to let the pytest use the max voltage from the command to check charger voltage.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1683ad3913b11a12aabe7afb814b531b5d20cd50

commit 1683ad3913b11a12aabe7afb814b531b5d20cd50
Author: Cheng-Han Yang <chenghan@google.com>
Date: Fri Jul 20 12:31:14 2018

pytest: Add 'use_max_voltage' arg in battery_current pytest

Add an argument to use max voltage instead of instant voltage
to check charger voltage in battery_current pytest.

BUG= chromium:856984 
TEST=manually test on DUT

Change-Id: I64dc775a1fcee4d82d2cf3974cf7c213bcd46d93
Reviewed-on: https://chromium-review.googlesource.com/1116759
Commit-Ready: Cheng-Han Yang <chenghan@chromium.org>
Tested-by: Cheng-Han Yang <chenghan@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>

[modify] https://crrev.com/1683ad3913b11a12aabe7afb814b531b5d20cd50/py/test/pytests/battery_current.py

Comment 2 by chenghan@chromium.org, Jul 21

Status: Fixed (was: Untriaged)

Comment 3 by jettrink@chromium.org, Aug 30 

How does one use this new flag during FAFT?

Comment 4 by chenghan@chromium.org, Aug 30 

The pytest is used for factory testing, not FAFT
►

Sign in to add a comment