Delay in removing generation action from accessory on navigation |
||||||
Issue descriptionChrome Version: 69.0.3473.0 (Canary) OS: Android Precondition: Passwords sync enabled. What steps will reproduce the problem? (1) Navigate to a sign up form. (e.g. on imdb.com). (2) Tap new password field. (3) Navigate to e.g. google.com and tap the search field. What is the expected result? The keyboard accessory shows up without a generation action button. What happens instead? The keyboard accessory shows up with the generation button which is then removed.
,
Jun 27 2018
(Please add for new bugs like these that they are blocking issue 853794 ... otherwise it's hard to keep track.)
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4531d6fadd87be520524aed7d974eb3d758d9c00 commit 4531d6fadd87be520524aed7d974eb3d758d9c00 Author: Ioana Pandele <ioanap@chromium.org> Date: Mon Jul 30 16:23:11 2018 Remove actions from keyboard accessory when hiding it This aims to fix the case in which when moving focus to a different field (for which the action doesn't apply), the accessory is first shown and then the action is removed. When this happens, there is a perceivable delay before the action button disappears. Bug: 856971 Change-Id: I1dfb63c513d109b74592870d3d63277b8237df25 Reviewed-on: https://chromium-review.googlesource.com/1142150 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#579060} [modify] https://crrev.com/4531d6fadd87be520524aed7d974eb3d758d9c00/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java [modify] https://crrev.com/4531d6fadd87be520524aed7d974eb3d758d9c00/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java [modify] https://crrev.com/4531d6fadd87be520524aed7d974eb3d758d9c00/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java [modify] https://crrev.com/4531d6fadd87be520524aed7d974eb3d758d9c00/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
,
Jul 31
,
Aug 1
This fixes a UI issue.
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ea2bc090ba9923a57f664b3049ab4316336d41d commit 6ea2bc090ba9923a57f664b3049ab4316336d41d Author: Ioana Pandele <ioanap@chromium.org> Date: Thu Aug 02 18:45:19 2018 [Merge M69] Remove actions from keyboard accessory when hiding it This aims to fix the case in which when moving focus to a different field (for which the action doesn't apply), the accessory is first shown and then the action is removed. When this happens, there is a perceivable delay before the action button disappears. Bug: 856971 Change-Id: I1dfb63c513d109b74592870d3d63277b8237df25 Reviewed-on: https://chromium-review.googlesource.com/1142150 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579060}(cherry picked from commit 4531d6fadd87be520524aed7d974eb3d758d9c00) Reviewed-on: https://chromium-review.googlesource.com/1161062 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#347} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/6ea2bc090ba9923a57f664b3049ab4316336d41d/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java [modify] https://crrev.com/6ea2bc090ba9923a57f664b3049ab4316336d41d/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java [modify] https://crrev.com/6ea2bc090ba9923a57f664b3049ab4316336d41d/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java [modify] https://crrev.com/6ea2bc090ba9923a57f664b3049ab4316336d41d/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ioanap@chromium.org
, Jun 27 2018