New issue
Advanced search Search tips

Issue 856966 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 863154
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in ProfileChooserView::CreateCurrentProfileView

Project Member Reported by ClusterFuzz, Jun 27 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5738256583622656

Fuzzer: bj_broddelwerk
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  ProfileChooserView::CreateCurrentProfileView
  ProfileChooserView::CreateProfileChooserView
  ProfileChooserView::ShowView
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=570225:570238

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5738256583622656

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 27 2018

Components: UI>Browser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: pnangunoori@chromium.org
Labels: M-69 Test-Predator-Wrong
Owner: droger@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the code search for the file, “profile_chooser_view.cc” assigning to concern owner from GIT blame.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7

@droger -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Thank You.

Comment 3 by droger@chromium.org, Jun 28 2018

Owner: tangltom@chromium.org
tentatively assigning to tangltom, assuming he's familiar with that code.

I don't think it's related to my CL, unless somehow browser()->profile() changes during the execution of the function. I don't think it's possible, but maybe Thomas could confirm.

Comment 4 by droger@chromium.org, Jun 28 2018

Thomas: is it possible that we're trying to create this view for a profile that has been deleted?
This should not be the case because the profilechooserview belongs to a browser and a browser belongs to a profile.
It's reproducible (with ClusterFuzz), but we have no idea how this testcase can actually happen with a real user.

Apparently, the user menu gets opened when in Incognito mode. This should not be possible and therefore has unexpected behavior (in this case it's a crash).
Project Member

Comment 7 by ClusterFuzz, Jul 11

ClusterFuzz has detected this issue as fixed in range 573652:573654.

Detailed report: https://clusterfuzz.com/testcase?key=5738256583622656

Fuzzer: bj_broddelwerk
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  ProfileChooserView::CreateCurrentProfileView
  ProfileChooserView::CreateProfileChooserView
  ProfileChooserView::ShowView
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=570225:570238
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=573652:573654

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5738256583622656

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jul 11

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5738256583622656 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Probably a duplicate of  bug 863154 
Mergedinto: 863154
Status: Duplicate (was: Verified)
Yes, thanks!

Sign in to add a comment