New issue
Advanced search Search tips

Issue 856955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

inspector-protocol/.../animation-multiple-frames.js in webkit_layout_tests failing on chromium.webkit/WebKit Win10

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 27 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of grt@chromium.org

inspector-protocol/.../animation-multiple-frames.js in webkit_layout_tests failing on chromium.webkit/WebKit Win10

Builders failed on: 
- WebKit Win10: 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10


 

Comment 1 by grt@chromium.org, Jun 27 2018

Components: Blink>Animation
Labels: OS-Linux OS-Windows Type-Bug
Also failing on WebKit Linux Trusty Leak. Here's the diff:

--- /b/s/w/ioqsjMmC/layout-test-results/inspector-protocol/animation/animation-multiple-frames-expected.txt
+++ /b/s/w/ioqsjMmC/layout-test-results/inspector-protocol/animation/animation-multiple-frames-actual.txt
@@ -16,7 +16,7 @@
 Frame appended
 Animation started: start time is valid
 Frame appended
-Animation started: start time is valid
+Animation started: invalid startTime!268.208000000052.268.208000000208
 Frame appended
 Animation started: start time is valid
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16a17d6847498a28b3d5ddb182d5b66adb76e954

commit 16a17d6847498a28b3d5ddb182d5b66adb76e954
Author: Greg Thompson <grt@chromium.org>
Date: Wed Jun 27 10:05:16 2018

inspector-protocol/animation/animation-multiple-frames.js is flaky.

BUG= 856955 
TBR=grt@chromium.org

Change-Id: I3dc85cc564100b27fc4c3cd2a584952c48dfb981
Reviewed-on: https://chromium-review.googlesource.com/1116550
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570717}
[modify] https://crrev.com/16a17d6847498a28b3d5ddb182d5b66adb76e954/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by grt@chromium.org, Jun 27 2018

Labels: -Sheriff-Chromium

Comment 4 by sunxd@chromium.org, Jun 27 2018

Labels: Test-Layout
Owner: dgozman@chromium.org
Test continuous to fail. :-( 

Assigning to test creator.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/

Failure from layout_tests_results:
--- e:\b\swarm_slave\w\ioh8dlth\layout-test-results\inspector-protocol/animation/animation-multiple-frames-expected.txt
+++ e:\b\swarm_slave\w\ioh8dlth\layout-test-results\inspector-protocol/animation/animation-multiple-frames-actual.txt
@@ -1,14 +1,14 @@
 Tests animation notifications from multiple frames.
+Frame appended
+Animation started: start time is valid
+Frame appended
+Animation started: invalid startTime!47.7539993792772.47.753999912858
 Frame appended
 Animation started: start time is valid
 Frame appended
 Animation started: start time is valid
 Frame appended
-Animation started: start time is valid
-Frame appended
-Animation started: start time is valid
-Frame appended
-Animation started: start time is valid
+Animation started: invalid startTime!84.6959983310699.84.6959989774227
 Frame appended
 Animation started: start time is valid
 Frame appended


Screen Shot 2018-07-02 at 5.26.44 PM.png
751 KB View Download
Owner: alph@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb297d9bbd8ec3dc6d0789045973e6d95a0c8761

commit cb297d9bbd8ec3dc6d0789045973e6d95a0c8761
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Jul 03 17:19:59 2018

DevTools: Fix rounding error in animation startTime calculations.

The test was flaky because of the rounding errors.

BUG= 856955 

Change-Id: I089ff4efa05935433c6f1cd3a89f8cbad26879d5
Reviewed-on: https://chromium-review.googlesource.com/1123768
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572265}
[modify] https://crrev.com/cb297d9bbd8ec3dc6d0789045973e6d95a0c8761/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cb297d9bbd8ec3dc6d0789045973e6d95a0c8761/third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-multiple-frames.js
[modify] https://crrev.com/cb297d9bbd8ec3dc6d0789045973e6d95a0c8761/third_party/blink/renderer/core/inspector/inspector_animation_agent.cc

Status: Fixed (was: Available)

Sign in to add a comment