Autofill Dropdown should be dismissed when Keyboard Accessory Sheet is triggered |
||
Issue descriptionWhat steps will reproduce the problem? (1) Tap a field (autofill dropdown and keyboard accessory open up) (2) Tap the Key icon in the accessory bar What is the expected result? The accessory sheet opens and the autofill dropdown is dismissed until a field is selected again. What happens instead? The accessory sheet opens but the autofill dropdown remains visible which might cause the accessory sheet to be overlayed by the popup.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fb97851c6fd6552e9f0f6192d42dbcc19cdaa6c commit 9fb97851c6fd6552e9f0f6192d42dbcc19cdaa6c Author: Friedrich Horschig <fhorschig@chromium.org> Date: Fri Aug 03 14:36:28 2018 [Android] Opening accessory sheet dismisses autofill popup If a user opens the keyboard accessory sheet, the autofill popup wasn't useful in their situation and can be dismissed. This removes the issue of the popup overlapping the accessory. Long-term, the popup will not exist at the same time as the accessory. Bug: 856951 Change-Id: I536c31bfc2ad189bb93867ebdf6b7914c4a556cb Reviewed-on: https://chromium-review.googlesource.com/1160230 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#580541} [modify] https://crrev.com/9fb97851c6fd6552e9f0f6192d42dbcc19cdaa6c/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java [modify] https://crrev.com/9fb97851c6fd6552e9f0f6192d42dbcc19cdaa6c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java [modify] https://crrev.com/9fb97851c6fd6552e9f0f6192d42dbcc19cdaa6c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java [modify] https://crrev.com/9fb97851c6fd6552e9f0f6192d42dbcc19cdaa6c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java [modify] https://crrev.com/9fb97851c6fd6552e9f0f6192d42dbcc19cdaa6c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
,
Aug 3
|
||
►
Sign in to add a comment |
||
Comment 1 by fhorschig@chromium.org
, Aug 2