recipe seems not mark InfraFailure as step exception |
|||
Issue descriptionWhile I am debugging crbug.com/854955, I found that raising InfraFailure does not make step purple. According to https://github.com/luci/recipes-py/blob/master/recipe_modules/step/api.py#L53, raising InfraFailure is expected to make the step purple. However, I could not find the code that catch InfraFailure and make the step shown as @@@STEP_EXCEPTION@@@ As far as I understand logdog annotator mark the step exception only if the line contains @@@STEP_EXCEPTION@@@.
,
Aug 20
,
Aug 20
I believe this is because currently annotee (The library responsible for converting recipe steps into annotations) takes the first step status it's given for a step, and ignores the rest. So if the compile step fails, it will stay failed, and cannot be converted into purple. We've been working around this by creating a new fake step, and giving that step the appropriate status.
,
Oct 18
|
|||
►
Sign in to add a comment |
|||
Comment 1 by s...@google.com
, Jul 10