Popup window omnibox is weird with new touch UI |
||||||
Issue descriptionChrome Version: 69.0.3464.0 OS: Chrome What steps will reproduce the problem? (1) Have the new touch UI enabled (2) Open a popup window (3) Click in the omnibox What is the expected result? - the omnibox is read only so shouldn't go into edit mode except to allow the user to copy the URL What happens instead? - a rounded blue border appears over the omnibox. This is weird as the omnibox area is rectangular - the omnibox suggest UI pops up. This is non-functional as the user cannot change the URL A few screenshots are attached.
,
Jun 29 2018
No, we shouldn't be drawing the focus ring in this case. I wasn't able to reproduce the popup appearing, I think that's zero suggest. I wonder if that's a separate issue that's not related to the new UI?
,
Jul 19
,
Jul 19
bklmn@ In popup windows, should page action icons be rounded (in order to match page action icons in normal windows) or rectangular (in order to match the popup windows' rectangular location bar)? See screenshot, top: popup window (rounded page action icons), middle: normal window (rounded icon), bottom: normal window with material refresh turned off (square icon).
,
Jul 19
bklmn@ 2 more questions, For popup windows, should the background switch to white when the location bar is focused as it does for normal windows, or should it remain gray? Currently, we can use the keyboard to highlight text in the omnibox by focusing it, then pressing shift+ left|right|home|end|(ctrl+left)|(ctr+left). The textfield cursor is invisible during these actions, yet it is being used to determine the starting point of the selection. For example, click in the middle of the location bar to focus it, then press shift+left to see the selection begin from where you clicked, even though there was no cursor to indicate the location. Not sure if this is intended to make it clear it's uneditable, or maybe we'd prefer to show some indication of the selection cursor.
,
Jul 19
jdonnelly@ regarding reproducing the popup appearing, u can click the location bar, then press page up & page down to make it appear. It seems in normal windows, page up, page down, up, and down are all mapped to traverse the omnibox suggestions even when the omnibox popup is closed. It seems the popup window ignores the up & down, but not the page up & page down. Should this be part of this bug or separated?
,
Jul 19
Ah, interesting. Yes, please file a separate bug for the page up/page down issue.
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59e6433d511beea5f4ec861d87f7677a53a638c4 commit 59e6433d511beea5f4ec861d87f7677a53a638c4 Author: manuk <manukh@chromium.org> Date: Thu Jul 19 20:30:32 2018 Hide location bar focus ring for popup windows. Popup windows display a selectable but non-editable location bar which should not display a focus ring. This was not an issue prior to material refresh, as the location bar displayed a focus ring only on mac. Bug: 856909 Change-Id: I5060e57546923a2e53bdd20bcd0c20dde7925bb0 Reviewed-on: https://chromium-review.googlesource.com/1144204 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#576607} [modify] https://crrev.com/59e6433d511beea5f4ec861d87f7677a53a638c4/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Jul 19
,
Jul 20
Tried to test the issue on chrome canary version 69.0.3497.0 using Windows 10 . Steps: --------- 1. Launched reported chrome 2. Enabled flag #top-chrome-md to touchable-refresh 3. Opened the popup- could not observe any focus ring appearing over the omnibox Attaching screencast for reference. manukh@ : Could you please review the attached screencast and and help in confirming the fix. Thanks.! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mpear...@chromium.org
, Jun 28 2018Components: UI>Browser>Omnibox
Labels: OS-Chrome
Owner: manukh@chromium.org
Status: Assigned (was: Untriaged)