Issue metadata
Sign in to add a comment
|
Update ChromeOS sys-libs/libcxx |
||||||||||||||||||||||||
Issue descriptionChromeOS is using libc++-4.0 [1], which is a year behind to the ToT, and that confuses Chromium build on C++17 mode [2]. Consider updating it to newer one. 1: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/sys-libs/libcxx/ 2: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942651846880127888%2F%2B%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout # This is due to the implementation of std::optional comparison, that was not implemented as the final C++17 spec at that time.
,
Jun 28 2018
Surprisingly, _LIBCPP_VERSION value in libc++-4.0.0-r12 package is 5000, though the code looks mostly like libc++4. That confuses a version detection-based workaround...
,
Jun 28 2018
,
Jun 28 2018
,
Jun 29 2018
Will plan to upgrade with next compiler roll which should happen soon after July 19th.
,
Jul 2
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1a945e6162df008887f74758e805d283af379dda commit 1a945e6162df008887f74758e805d283af379dda Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jul 06 14:53:56 2018 libcxx/libcxxabi: Update to use latest aosp versions for llvm-next. Update libc++ and libc++abi to current aosp trunk r334917 for llvm-next. Does not change the current libc++ in Chrome OS. BUG=chromium:858896 BUG= chromium:856904 TEST=llvm-next builds. CQ-DEPEND=CL:1119571 Change-Id: Ibbfa6a3d7545d015d60fd6f8f376ed8618d9b525 Reviewed-on: https://chromium-review.googlesource.com/912448 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> [add] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxxabi/files/libcxxabi-7-use-libgcc_eh.patch [add] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxx/files/libcxx-7-use-libgcc_eh.patch [rename] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxx/libcxx-4.0.0-r14.ebuild [delete] https://crrev.com/c7333df11f788c834d164dc7f418ce7303f36f4b/sys-libs/libcxxabi/libcxxabi-9999.ebuild [rename] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxxabi/libcxxabi-4.0.0-r35.ebuild
,
Jul 28
,
Aug 17
libc++ was updated in https://chromium-review.googlesource.com/1168987
,
Aug 17
Thanks! I confirmed that works perfectly. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tzik@chromium.org
, Jun 27 2018Labels: OS-Chrome