Check failed: !EndsWithSlash(s) in GN on Android analyze |
|||
Issue descriptionI accidentally pushed a GN linux binary that contained DCHECKs, tryjob'd in https://chromium-review.googlesource.com/c/chromium/src/+/1112840 and that resulted in: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/22868 compute_grit_inputs_for_analyze=true""" to /b/swarming/w/ir/cache/builder/src/out/Release/args.gn. /b/swarming/w/ir/cache/builder/src/third_party/gn/gn gen //out/Release --check [139684238980928:0626/185502.182343:FATAL:source_file.cc(21)] Check failed: !EndsWithSlash(s). //out/Release/gen/tools/perf/contrib/vr_benchmarks/vr_assets_profile/ -> returned -6 GN gen failed: -6 # To recreate the file passed to argv[0] (input_path): % cat > /b/swarming/w/ir/tmp/t/tmpuTRA5E.json <<EOF {"additional_compile_targets": ["cronet_test_instrumentation_apk", "monochrome_static_initializers"], "files": ["DEPS", "build/util/gn_cleanup.py", "tools/mb/mb.py", "tools/mb/mb_unittest.py"], "test_targets": ["angle_unittests", "base_junit_tests", "base_unittests", "blink_common_unittests", "blink_heap_unittests", "blink_platform_unittests", "boringssl_crypto_tests", "boringssl_ssl_tests", "breakpad_unittests", "cacheinvalidation_unittests", "capture_unittests", "cast_unittests", "cc_unittests", "chrome_junit_tests", "chrome_public_test_apk", "chrome_public_test_vr_apk", "chrome_sync_shell_test_apk", "components_background_task_scheduler_junit_tests", "components_browsertests", "components_gcm_driver_junit_tests", "components_invalidation_impl_junit_tests", "components_policy_junit_tests", "components_signin_junit_tests", "components_unittests", "components_variations_junit_tests", "components_web_restrictions_junit_tests", "content_browsertests", "content_junit_tests", "content_shell_test_apk", "content_unittests", "crypto_unittests", "device_junit_tests", "device_unittests", "display_unittests", "events_unittests", "gcm_unit_tests", "gfx_unittests", "gin_unittests", "gl_tests", "gl_unittests", "google_apis_unittests", "gpu_unittests", "ipc_tests", "jingle_unittests", "junit_unit_tests", "latency_unittests", "libjingle_xmpp_unittests", "media_base_junit_tests", "media_blink_unittests", "media_service_unittests", "media_unittests", "midi_unittests", "mojo_test_apk", "mojo_unittests", "monochrome_apk_checker", "net_junit_tests", "net_unittests", "sandbox_linux_unittests", "service_junit_tests", "services_unittests", "shell_dialogs_unittests", "skia_unittests", "sql_unittests", "storage_unittests", "ui_android_unittests", "ui_base_unittests", "ui_junit_tests", "ui_touch_selection_unittests", "unit_tests", "url_unittests", "viz_unittests", "vr_common_unittests", "vr_pixeltests", "webapk_client_junit_tests", "webapk_shell_apk_junit_tests", "webkit_unit_tests", "wtf_unittests"]} EOF % step returned non-zero exit code: 250 I don't think this is a behavior problem, but we should figure out if that DCHECK is actually valid.
,
Jun 27 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35383539aa83f27185a661215773ece946535676 commit 35383539aa83f27185a661215773ece946535676 Author: Scott Graham <scottmg@chromium.org> Date: Wed Jun 27 16:27:35 2018 Revert "Pull GN via CIPD package" This reverts commit 0895c7977a5c312aca132b23a3a9d46f78f77ee4. Reason for revert: Missed a hardcoded gn location: https://crbug.com/857107. Original change's description: > Pull GN via CIPD package > > The gn binary will be downloaded into third_party/gn. This CL rolls > buildtools forward to a revision where gn is no longer in buildtools. > > Because buildtools has no way to cleanup after itself, add > build/util/gn_cleanup.py to delete the old binaries so that we don't > accidentally depend on them. > > Update mb.py to use the new location. > > Update explicit location in ios/web_view/BUILD.gn for the new location. > > Update explicit location in > tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new > location. > > Update explicit location in tools/licenses.py with for the new location. > > Bug: 855791 > Bug: 794764 > Bug: 856883 > Bug: 856884 > Bug: 856878 > Bug: 856899 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116 > Reviewed-on: https://chromium-review.googlesource.com/1112840 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570792} TBR=dpranke@chromium.org,scottmg@chromium.org Change-Id: I89e180710b5ce483106fa3b4ff6e8dec06780c07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855791, 794764 , 856883, 856884 , 856878, 856899 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1117219 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570799} [modify] https://crrev.com/35383539aa83f27185a661215773ece946535676/DEPS [delete] https://crrev.com/d0ed5774569fc56f4a0c74affafda8a7ad2a02aa/build/util/gn_cleanup.py [modify] https://crrev.com/35383539aa83f27185a661215773ece946535676/ios/web_view/BUILD.gn [modify] https://crrev.com/35383539aa83f27185a661215773ece946535676/tools/licenses.py [modify] https://crrev.com/35383539aa83f27185a661215773ece946535676/tools/mb/mb.py [modify] https://crrev.com/35383539aa83f27185a661215773ece946535676/tools/mb/mb_unittest.py [modify] https://crrev.com/35383539aa83f27185a661215773ece946535676/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fed0e8ec393c317037a824b63b3e9690b8b0a4fc commit fed0e8ec393c317037a824b63b3e9690b8b0a4fc Author: Scott Graham <scottmg@chromium.org> Date: Thu Jun 28 05:02:14 2018 Pull GN via CIPD package This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1112840. The gn binary will be downloaded into third_party/gn. This CL rolls buildtools forward to a revision where the gn binary is a stub that prints an error message and returns 1. This is to avoid depending on the old location, and helping users relying on gn auto regen. Update mb.py to use the new location. Update explicit location in ios/web_view/BUILD.gn for the new location. Update explicit location in tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new location. Update explicit location in tools/licenses.py with for the new location. Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py. Bug: 855791 Bug: 856883 Bug: 856884 Bug: 856878 Bug: 856899 Bug: 857107 Bug: 857110 Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1117264 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571031} [modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/DEPS [modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/ios/web_view/BUILD.gn [modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/testing/libfuzzer/gen_fuzzer_owners.py [modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/licenses.py [modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/mb/mb.py [modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/mb/mb_unittest.py [modify] https://crrev.com/fed0e8ec393c317037a824b63b3e9690b8b0a4fc/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8962649114490c145c5cba76fe290752014d6432 commit 8962649114490c145c5cba76fe290752014d6432 Author: Xiaoqian Dai <xdai@chromium.org> Date: Thu Jun 28 17:07:46 2018 Revert "Pull GN via CIPD package" This reverts commit fed0e8ec393c317037a824b63b3e9690b8b0a4fc. Reason for revert: It broke most of the chrome_informational builders at BuildPackages stage. See crbug.com/857133 for details. Original change's description: > Pull GN via CIPD package > > This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1112840. > > > The gn binary will be downloaded into third_party/gn. This CL rolls > buildtools forward to a revision where the gn binary is a stub that > prints an error message and returns 1. This is to avoid depending > on the old location, and helping users relying on gn auto regen. > > Update mb.py to use the new location. > > Update explicit location in ios/web_view/BUILD.gn for the new location. > > Update explicit location in > tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new > location. > > Update explicit location in tools/licenses.py with for the new location. > > Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py. > > Bug: 855791 > Bug: 856883 > Bug: 856884 > Bug: 856878 > Bug: 856899 > Bug: 857107 > Bug: 857110 > Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1117264 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571031} TBR=dpranke@chromium.org,scottmg@chromium.org Change-Id: I28962c879b7bc24e809b29427122bb425e9450a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855791, 856883, 856884 , 856878, 856899 , 857107, 857110 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118825 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#571170} [modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/DEPS [modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/ios/web_view/BUILD.gn [modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/testing/libfuzzer/gen_fuzzer_owners.py [modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/licenses.py [modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/mb/mb.py [modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/mb/mb_unittest.py [modify] https://crrev.com/8962649114490c145c5cba76fe290752014d6432/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 27 2018