New issue
Advanced search Search tips

Issue 856868 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Keyup event isn't fired for Q key in Chrome Canary 69

Reported by potassiu...@gmail.com, Jun 27 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3473.0 Safari/537.36

Steps to reproduce the problem:
1. Type a Javascript below:

window.onkeyup=function(){
	console.log("up");
}

window.onkeydown=function(e){
	console.log(e.code);
}

2. Open a Javascript conosole of Devtools in Chrome Canary 69.0.3473.0

3. ress "Q" key and other keys several times

4. Check the output of the console.

What is the expected behavior?
Keyup event is fired on Q key.
Keyup event should be fired on release of alphabet keys.

For example:

Keys:                 console says:
Press A         ->  KeyA
Release A      ->  up
Press Q         ->  KeyQ
Release Q      ->  up

What went wrong?
Keyup event isn't fired on Q key.
It is fired well on other keys.

For example:

Keys:                  console says:
Press A         ->   KeyA
Release A      ->  up
Press Q         ->  KeyQ
Release Q      ->  NOTHING IS OUTPUTTED

Did this work before? Yes Chrome  67.0.3396.99

Chrome version: 69.0.3473.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

* It works on Chrome 67, so this is a regression.
* This bug was already seen in Chrome Canary 69.0.3472.3
* I've reported the same bug in  Issue 856485 , but it has unnecessary information. So I would like to merge  Issue 856485  into this issue.
 
chrome_bug6.mp4
9.6 MB View Download
Typo:

Wrong:     3. ress "Q" key
Correct:    3. Press "Q" key

Comment 2 Deleted

Sample URL: http://sinst.html.xdomain.jp/zengaku/jkkn/chrome_bug6.html

*It works well on Firefox, too.
Labels: Needs-Triage-M69 Needs-Bisect
Components: UI>Browser
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET M-69 RegressedIn-69 hasbisect Target-69 FoundIn-69 OS-Linux Pri-1
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 and Ubuntu 17.10 using chrome reported version #69.0.3473.0. Issue is not seen in OS-Mac.

Bisect Information:
=====================
Good build: 69.0.3466.0
Bad Build : 69.0.3472.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/db53bdce09655a51dc7b6be71e928c5afadf63ee..a0c9298d9d825c612b2e5e5ba606e57f1ec91c6d

From the above change log suspecting below change
Change-Id: I2dfeb60c6efb24816b73db3f0e014a0deb648be5
Reviewed-on: https://chromium-review.googlesource.com/1104884

thomasanderson@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-69 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!
Components: -Blink
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84

commit 18aedf278c1a57b3a1d5a6ee68c011d1e206aa84
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jun 28 00:17:19 2018

Fix missing key release event for 'Q' key in browser windows

BUG= 856868 
R=sky

Change-Id: I4a1059e88aee7d6dadbb277742c770a11c1e7042
Reviewed-on: https://chromium-review.googlesource.com/1117274
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570964}
[modify] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/chrome/browser/ui/views/confirm_quit_bubble_controller.cc
[modify] https://crrev.com/18aedf278c1a57b3a1d5a6ee68c011d1e206aa84/chrome/browser/ui/views/confirm_quit_bubble_controller_unittest.cc

Status: Fixed (was: Started)
 Issue 856485  has been merged into this issue.

Sign in to add a comment