New issue
Advanced search Search tips

Issue 856860 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 601600
issue 601601
issue 603202
issue 612222
issue 615920
issue 629381
issue 633442
issue 656849
issue 656852
issue 661022
issue 661023
issue 669330
issue 673598
issue 673599
issue 675823
issue 677870
issue 677871
issue 679584
issue 679591
issue 681720
issue 681726
issue 686985
issue 691856
issue 698951
issue 703448
issue 708025
issue 710303
issue 712489
issue 714938
issue 714939
issue 727438
issue 736971
issue 738960
issue 745186
issue 745188
issue 748327
issue 753196
issue 757685
issue 759923
issue 768635
issue 773163
issue 775333
issue 775345
issue 777692
issue 779898
issue 782078
issue 784717
issue 787268
issue 791843
issue 797605
issue 800191
issue 802108
issue 804640
issue 804641
issue 809335
issue 813679
issue 813683
issue 816771
issue 821248
issue 823570
issue 849509
issue 851787



Sign in to add a comment

Disable unimportant CompositorTimingHistory UMAs

Project Member Reported by briander...@chromium.org, Jun 27 2018

Issue description

Many of them aren't used often and need an audit since they use a significant amount of bandwidth.
 

Comment 1 by sadrul@chromium.org, Jun 27 2018

Cc: sadrul@chromium.org
Components: Internals>GPU>Metrics
Labels: -Pri-3 Pri-2
Owner: yiyix@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e8ede6cc6f5ab8878695e6e0d45a4743b9018d

commit b1e8ede6cc6f5ab8878695e6e0d45a4743b9018d
Author: yiyix <yiyix@chromium.org>
Date: Wed Jul 11 20:38:26 2018

Remove metrics in Browser.NonCriticalPath

All frames are in the critical path in Browser. i.e., smooth
does not take priority. So no data is reported in metrics
BeginMainFrameIntervalNotCritical2 and
BeginMainFrameQueueDurationNotCritical2.

BUG= 856860 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibd58bb31ebfdc21f0aae6f5feabbc22ed8fbbcf1
Reviewed-on: https://chromium-review.googlesource.com/1133427
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574313}
[modify] https://crrev.com/b1e8ede6cc6f5ab8878695e6e0d45a4743b9018d/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/b1e8ede6cc6f5ab8878695e6e0d45a4743b9018d/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da23899bd6a075e086bfc2527cd5c9d37d983ba

commit 3da23899bd6a075e086bfc2527cd5c9d37d983ba
Author: yiyix <yiyix@chromium.org>
Date: Fri Jul 13 05:21:33 2018

gpu metrics: Remove Scheduling.Browawe.DrawInterval*

Both metrics browser.DrawIntervalWithMainThreadAnimations2 and
browser.DrawIntervalWithCompositedAnimations2 do not report
meaningful data.

Bug:  856860 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2f65962ccc1a4535b4a166298a79c673b5ae746b
Reviewed-on: https://chromium-review.googlesource.com/1134588
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574843}
[modify] https://crrev.com/3da23899bd6a075e086bfc2527cd5c9d37d983ba/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/3da23899bd6a075e086bfc2527cd5c9d37d983ba/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f34b2a3ccb0c355f461ae6a5365fb4db3a98dc

commit 97f34b2a3ccb0c355f461ae6a5365fb4db3a98dc
Author: yiyix <yiyix@chromium.org>
Date: Fri Jul 13 22:13:05 2018

Removing Scheduling.Browser.pending_tree related metrics

Since there is only active tree on browser side, metrics that
measure the pending_tree related information does not report any
data.

Note that no change in the code is needed because the metric is
initiated in CreatePendingTree, which is not called in the browser
side.

Bug:856860

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I40c36c62131e309fabaedab298b249307a9c1c29
Reviewed-on: https://chromium-review.googlesource.com/1133971
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575090}
[modify] https://crrev.com/97f34b2a3ccb0c355f461ae6a5365fb4db3a98dc/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/97f34b2a3ccb0c355f461ae6a5365fb4db3a98dc/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733d25c2dd5f717fae901bb8c5532b75036387c2

commit 733d25c2dd5f717fae901bb8c5532b75036387c2
Author: yiyix <yiyix@chromium.org>
Date: Sun Jul 15 05:32:00 2018

Remove metrics Scheduling.*.SwapAckWasFast

The metrics Scheduling.*.SwapAckWasFast records True if the swap
ack was received within approximately 8 seconds of the swap. Based
on the past few month of data, this metrics always report true,
true -> 100%. In addition, metrics Scheduling.*.SwapToAckLatency2
measures the same data - it reports the exact time that takes for
the swap ack to return after a swap.

Bug:  856860 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I00cf9e545a9a55054fe7dd8af948693625cac08b
Reviewed-on: https://chromium-review.googlesource.com/1134040
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575177}
[modify] https://crrev.com/733d25c2dd5f717fae901bb8c5532b75036387c2/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/733d25c2dd5f717fae901bb8c5532b75036387c2/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e007029d8038716adb8c0a66b46e01b4b4a9a6b7

commit e007029d8038716adb8c0a66b46e01b4b4a9a6b7
Author: yiyix <yiyix@chromium.org>
Date: Tue Aug 28 19:40:07 2018

CompositorTimingHistory metrics: remove Scheduling.Browser.MainAndImplFrameTimeDelta2

It records every time the compositor draws with a new active tree. For
browser side, more than 90% of time the main-side started and finished
within the same frame interval as the impl-side. This is because there
is no pending tree on Browser side. Since the data it recorded is not
important, remove the metrics Scheduling.Browser.MainAndImplFrameTimeDelta2

Bug:  856860 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibfbf715f644df1ed5c68c800a4ca9703622a555e
Reviewed-on: https://chromium-review.googlesource.com/1189550
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586815}
[modify] https://crrev.com/e007029d8038716adb8c0a66b46e01b4b4a9a6b7/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/e007029d8038716adb8c0a66b46e01b4b4a9a6b7/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922cdb48cf63acb860c279a12736c04a964fc657

commit 922cdb48cf63acb860c279a12736c04a964fc657
Author: yiyix <yiyix@chromium.org>
Date: Tue Aug 28 22:33:22 2018

CompositorTimingHistory metrics: remove Scheduling.Browser.ActivateDuration2

Scheduling.Browser.ActivateDuration records the time it takes for the
compositor to activate the pending tree. Since there is no pending tree
on browser side, the recorded information is not useful. Removing the metrics
Scheduling.Browser.ActivateDuration2

Bug:  856860 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id178100668e35ff64313867726941e570202083f
Reviewed-on: https://chromium-review.googlesource.com/1189551
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586893}
[modify] https://crrev.com/922cdb48cf63acb860c279a12736c04a964fc657/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/922cdb48cf63acb860c279a12736c04a964fc657/tools/metrics/histograms/histograms.xml

Status: Closed (was: Assigned)
I have disabled all the unimportant ones in CompositorTimingHistory.

Sign in to add a comment