Browser doesn't launch via Telemetry on Pixel 2 with Android P |
||||||||
Issue descriptionIn Issue 855660 we set up trybots against new Pixel 2 phones running Android P. Unfortunately Chromium doesn't launch on them via Telemetry, so none of the GPU tests would work. Here's a test CL: https://chromium-review.googlesource.com/1115802 and this tryjob: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/gpu-manual-try-android-p-pixel-2-32/2 All of the shards failed. The browser didn't start successfully in any of them. See this one: https://chromium-swarm.appspot.com/task?id=3e5735a6d8aa1410&refresh=10&show_raw=1 Log excerpt: 06-26 23:20:49.688 5351 5367 F chromium: [FATAL:time_clamper.cc(18)] Check failed: time_seconds >= 0 (-111.766 vs. 0) 06-26 23:20:49.688 5351 5367 F chromium: #00 0xcded7acd /data/app/org.chromium.chrome-uwg2QrPFomw3wAUAHUmb1A==/lib/arm/libchrome.so+0x021f0acd 06-26 23:20:49.688 5351 5367 F chromium: #01 0xcf1e4bdd /data/app/org.chromium.chrome-uwg2QrPFomw3wAUAHUmb1A==/lib/arm/libchrome.so+0x034fdbdd 06-26 23:20:49.688 5351 5367 F chromium: #02 0xcf7bb85f /data/app/org.chromium.chrome-uwg2QrPFomw3wAUAHUmb1A==/lib/arm/libchrome.so+0x03ad485f 06-26 23:20:49.688 5351 5367 F chromium: #03 0xcf7bae5b /data/app/org.chromium.chrome-uwg2QrPFomw3wAUAHUmb1A==/lib/arm/libchrome.so+0x03ad3e5b 06-26 23:20:49.688 5351 5367 F chromium: #04 0xcf7bae0b /data/app/org.chromium.chrome-uwg2QrPFomw3wAUAHUmb1A==/lib/arm/libchrome.so+0x03ad3e0b Are we testing Chrome on Android P yet? Is this a known issue?
,
Jun 27 2018
GPU's the first to have P automation.
,
Jun 27 2018
(though I have successfully run tests against P locally)
,
Jun 27 2018
I have tried it locally with the same OS version, same gn args and almost the same run_gpu_integration_test.py args, and it worked. I don't know how the swarming environment differs.
,
Jun 27 2018
Thanks Yuly for trying this out. How can we proceed? Maybe the Swarming bots do something in their setup which doesn't quite work on P, and it breaks Chromium's timers, or similar.
,
Jun 27 2018
Perhaps I was to early to celebrate. Looks like the tests start failing at some point even locally. Unfortunately, I didn't log into a file, so I only had logs of last ~90 tests out of ~2700 when I came in today, so I don't have good info. I've started running the suite again, and some tests are failing, but the suite seems to recover after that, even though I get "Chrome keeps crashing" window on the phone. One pattern that worries me a bit is this: [host]> /usr/local/google/work/clank/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s FA8121A02969 forward --no-rebind tcp:35123 localabstract:chrome_devtools_remote AndroidReverseForwarder started between 127.0.0.1:35123 and localabstract:chrome_devtools_remote Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Websocket at ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) not yet ready: [Errno 104] Connection reset by peer Got devtools config: ws://127.0.0.1:35123/devtools/browser (remote=localabstract:chrome_devtools_remote) Successfully connected to org.chromium.chrome DevTools client
,
Jun 27 2018
do note that the devil version of adb is *very* out of date at this point -- iirc, I tried updating it to 1.0.36 or 1.0.39 a while back only to have it get reverted after breaking some subset of telemetry tests. dunno if that's responsible, but it's worth revisiting once I upgrade platform-tools in chromium.
,
Jun 27 2018
I just finished a second local run, and didn't see as many failures as before. Other than the errors in #6, didn't see anything else in the logs. One other concern I have is that P doesn't seem to like us restarting the browser - it think that the application keeps crashing and shows a pop-up asking what to do with it. Also seems to navigate to the App settings where the Uninstall button is. Hope this doesn't interfere with the testing.
,
Jun 27 2018
Thanks for re-testing. We should report these issues to the Android team. Do you have any appropriate contacts? Raising to P2, because we should start addressing these issues now.
,
Jul 18
dansnyder@ found the same problem was happening on some Cast devices and proposed a patch which I've uploaded for him at https://chromium-review.googlesource.com/1142238 .
,
Jul 18
,
Jul 19
John, is there a bug for #7? Sounds like updating adb is something we should be doing sooner rather than later.
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ebb714c18a2ec435ac6ed9532435330dcbef44d commit 0ebb714c18a2ec435ac6ed9532435330dcbef44d Author: Kenneth Russell <kbr@chromium.org> Date: Fri Jul 20 22:03:35 2018 Handle negative times in TimeClamper::ClampTimeResolution. Patch from dansnyder@. Negative times are being seen on certain platforms (the Android P preview and some Cast devices, in particular). Handle them gracefully rather than asserting. Bug: 856858 Tbr: jochen@chromium.org Change-Id: Ib05cb8534bec9e6a95df2f989a9d65fedfeece0b Reviewed-on: https://chromium-review.googlesource.com/1142238 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#577005} [modify] https://crrev.com/0ebb714c18a2ec435ac6ed9532435330dcbef44d/gin/v8_platform.cc [modify] https://crrev.com/0ebb714c18a2ec435ac6ed9532435330dcbef44d/third_party/blink/renderer/platform/time_clamper.cc [modify] https://crrev.com/0ebb714c18a2ec435ac6ed9532435330dcbef44d/third_party/blink/renderer/platform/time_clamper_test.cc
,
Jul 20
Trying running WebGL 2.0 conformance on Android P again after the above fix: https://chromium-review.googlesource.com/1115802 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/gpu-manual-try-android-p-pixel-2-32/3
,
Jul 23
Looks like it worked! All that's left is to suppress the 43 failing tests :(
,
Jul 23
It's a relief that the browser now runs via Telemetry on this device. Let's track the suppression of the new test failures in Issue 858879 .
,
Jul 23
Woo hoo, thanks for the hard work pioneering Telemetry tests on this device!
,
Nov 7
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kbr@chromium.org
, Jun 27 2018