New issue
Advanced search Search tips

Issue 856857 link

Starred by 1 user
Status: Started
Owner:
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Investigate occurence of SavePageResult::CANCELLED when publishing pages.

Project Member Reported by petewil@chromium.org, Jun 27 2018 
Our histogram data shows that occasionally publishing an offline page fails with the CANCELLED result.  In theory, this shouldn't happen, because it means that the Java OfflinePageItem list is out of date with the OfflinePageModel.  To investigate, we're adding histograms to help track the source of the error.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7978388a7a26191934f712595b43c37ac867d491

commit 7978388a7a26191934f712595b43c37ac867d491
Author: Pete Williamson <petewil@chromium.org>
Date: Thu Jun 28 21:16:51 2018

Add UMA to help find out how we get CANCELLED when publshing pages.

Sometimes publishing an offline page results in the CANCELLED error.
Add some UMA to help discover how the cancelled results happen.

Bug: 856857
Change-Id: I14f35135ad9c76bb4093cce57c49a5b888a7c2df
Reviewed-on: https://chromium-review.googlesource.com/1116178
Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571263}
[modify] https://crrev.com/7978388a7a26191934f712595b43c37ac867d491/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/7978388a7a26191934f712595b43c37ac867d491/chrome/browser/offline_pages/android/offline_page_bridge.h
[modify] https://crrev.com/7978388a7a26191934f712595b43c37ac867d491/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7978388a7a26191934f712595b43c37ac867d491/tools/metrics/histograms/histograms.xml

Comment 2 by petewil@chromium.org, Aug 9 

Looking at Dev and Canary results from M69, we do still see some cases of CANCELLED, but none recently.  The change is in build 69.3451, but we do see one instance in 69.3452 Dev, so we need to investigate a bit more.
►

Sign in to add a comment