New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856846 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 732555



Sign in to add a comment

Android SurfaceSync: Touch is sometimes offset by top-bar height

Project Member Reported by ericrk@chromium.org, Jun 26 2018

Issue description

When running with Android SurfaceSync enabled, I frequently hit cases where my touch input is offset by the height of a missing top-control (it's as though the touch system thinks the top controls are visible, while the display system thinks they are hidden).

To repro:

1) Load reddit.com
2) Scroll up / down and try clicking a link.
3) Occasionally your tap will be offset by the height of the top-bar.
 
Have you seen this recently? Is this still a problem?
Cc: sadrul@chromium.org riajiang@chromium.org
Can you try with and without VizHitTestDrawQuad feature to see if that's causing the problem?
Status: WontFix (was: Available)
I haven't seen this for a few weeks... Closing out... But please re-open if anyone notices this.
Can still reproduce on Canary 70.0.3507.0. See video here: https://drive.google.com/file/d/1GZ2iZtzJ08MdyHrq53hNqyxmvtQvIIvA/view?usp=sharing
Thanks for the video seldnplan@! Can you repro this without Android SurfaceSync? Is VizHitTestDrawQuad turned on (you can check it in chrome://flags)?
I can't seem to repro this with VizHitTestDrawQuad without Android SurfaceSync
Not sure what SurfaceSync is, but I can confirm that behavior persists with VizHitTestDrawQuad turned on.
I just tested it again with Canary 70.0.3508.0 on pixel phone with VizHitTestDrawQuad turned on, on the same site (reddit Android) but still couldn't repro it. Can you share your repro steps/ device etc. for how to repro this consistently?
I just open up www.reddit.com/r/Android and try to click on a link after making sure that the address bar is hidden. Also have to ensure that it's in desktop mode (if on the mobile website, this can be done from the hamburger menu on the top right). I consistently find that my clicks are offset by the height of the address bar.
Thanks! Yes that's what I tried: Canary 70.0.3508.0, VizHitTestDrawQuad turned on, pixel phone on www.reddit.com/r/Android desktop mode; clicking with both address bar present and hidden worked fine for me. Which device are you using?
Pixel 2 XL. 
Attached a test video on pixel 2 xl, did I miss any steps you were doing to repro?
output.mp4
9.2 MB View Download
I just realized that I also have the Duet flag enabled. Disabling it seems to do the trick. Could you try it with it enabled and see if it's reproducible?

I searched for "Duet" but no flag came up, what's the full name?
It is at chrome://flags/#enable-chrome-duet on my device.
Also, note that you usually have to restart the browser twice for the flag to take effect.
Cc: mdjones@chromium.org
+mdjones@ who updated the chrome-duet feature name: I can't seem to find this flag in chrome://flags, could you point me to the right place and if there's a doc about what this feature does? Thanks!
This regression is now also in Chrome Beta 70.0.3538.57. Without any flags turned on, I was presented with the default option of bottom navigation. 

The video here will better explain it: https://drive.google.com/file/d/13MmN_GqFHVcaOD9kxIudjoiXVCJDbkhm/view?usp=drivesdk
I tried chrome beta 70.0.3538.64 but didn't have the bottom navigation and it worked fine - can you paste the variations under chrome://version?
Here it is:

Google Chrome	70.0.3538.57 (Official Build) beta (32-bit)
Revision	ccccfd03e65c41ad14b332e123df51131f8b8669-refs/branch-heads/3538@{#946}
OS	Android 9.0.0; Pixel 2 XL Build/PPR2.180905.005
Google Play services	SDK=12848000; Installed=14367037; Access=1p
JavaScript	V8 7.0.276.27
User Agent	Mozilla/5.0 (Linux; Android 9; Pixel 2 XL) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.57 Mobile Safari/537.36
Command Line	--use-mobile-user-agent --top-controls-show-threshold=0.5 --top-controls-hide-threshold=0.5 --use-mobile-user-agent --enable-pinch --enable-viewport --validate-input-event-stream --enable-longpress-drag-selection --touch-selection-strategy=direction --main-frame-resizes-are-orientation-changes --disable-composited-antialiasing --enable-dom-distiller --flag-switches-begin --flag-switches-end
Executable Path	No such file or directory
Profile Path	/data/user/0/com.chrome.beta/app_chrome/Default
Variations	411b6d4e-3f4a17df
7eb20865-3f4a17df
45514eb0-3f4a17df
8b81f22b-3f4a17df
609c5d64-a3a14831
288ddd9a-a3a14831
a6c4c423-33d01e57
853359fa-3f4a17df
3e006338-3f4a17df
66df3e9d-a3a14831
b7e2524c-3f4a17df
a6674cf-1e5d42aa
7e4bc10d-5d0302cf
b1681d28-803f8fc4
cc20827f-5e2e3697
241fff6c-ca7d8d80
8502ae4f-e1031ab5
38eb801c-3f4a17df
ed32657-3f4a17df
d35aec66-3f4a17df
1d773dec-3f4a17df
9def365c-5d0302cf
236d5d9e-6005c22c
47e5d3db-3d47f4f4
125b7f68-26e7b859
4bf94d2-26e7b859
d442dfb7-ca7d8d80
9ca1387e-f23d1dea
71ed337-7c7ea110
1149accc-5c943877
67941188-3f4a17df
a582a1b8-ad75ce17
e9de5187-5acf5edd
8ee5ed19-ca7d8d80
74658432-ca7d8d80
785e78-f23d1dea
5e3a236d-59e286d0
9b4c4257-6ad6e56e
27f3523b-2db9361
cfef46e7-8d65f83d
c157e591-3f4a17df
c364a20-3f4a17df
566db8be-5c943877
1eebe54f-5c943877
4ea303a6-f23d1dea
fe660e6c-f5a41e31
6e6e0c7e-3f17a7d8
95876445-ca7d8d80
d92562a9-6014a724
2c1d398c-3f4a17df
cc54eb06-803f8fc4
4932440-d21eb72d
3227ca1f-b4c13967
2afd34e2-869c3507
c332d3b5-3f4a17df
51b9b54d-f23d1dea
7345ea6-3f4a17df
4bc337ce-55ac272c
17507c76-3d47f4f4
494d8760-52325d43
3ac60855-486e2a9c
f296190c-19dcaa1a
4442aae2-d7f6b13c
ed1d377-e1cc0f14
75f0f0a0-d7f6b13c
e2b18481-bca011b3
e7e71889-4ad60575
1e902a37-f23d1dea
cc73f8a1-ca02b375
10a311eb-28165b59
8834fcca-cf4f6ead
6204e469-f23d1dea
I noticed that both Viz hit-testing and chrome duet are enabled in your variations; I tried turning on both on beta but failed to repro

Sign in to add a comment