Trybots shouldn't retry without patch if a swarming task times out |
||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/79854 is a sample build It does the without patch runs, when it shouldn't. One of the tasks in the failed step, webkit_layout_tests, failed due to capacity. Retrying without patch is useless here.
,
Jun 27 2018
Are you confusing "timeout" with "expired"? The mac build you linked failed because the test ran for too long and hit the swarming timeout (https://chromium-swarm.appspot.com/task?id=3e4e7f926b986010). Nothing to do with capacity. That we retry it w/o patch makes sense. If a CL bumps a test's runtime over a limit, we should expose that signal to the author.
,
Jun 27 2018
Ah whoops, you're right. I'll look for cases where it expires, and see if it does without patch retries.
,
Jan 3
|
||
►
Sign in to add a comment |
||
Comment 1 by martiniss@chromium.org
, Jun 26 2018