Build aheads is triggering Android builds on non-linux bots. |
|||
Issue descriptionWe have had several failures like this: https://ci.chromium.org/p/chromium/builders/luci.chromium.findit/findit_variable/5281 It seems that for some reason build-aheads is not requiring that android builds be triggered on os:Linux bots.
,
Jun 27 2018
It seems this was due to a misconfiguration. chromium.Android had no dimensions specified, and build-aheads is not using swarmbucket dynamic dimensions (working on that change today)
,
Jun 27 2018
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5a3ef5c2aeab17744a59ff580ea38a96c7e1af95 commit 5a3ef5c2aeab17744a59ff580ea38a96c7e1af95 Author: Roberto Carrillo <robertocn@google.com> Date: Wed Aug 01 21:27:23 2018 [Findit] Use ['task_slices'][0] to get properties off of a task def. The 'properties' key is no longer present in the top level of the task definition, but in the task slices. For our purposes the properties of the first task slice is what we need to determine the dimensions to run the task. R=chanli,lijeffrey,iannucci Bug: 856828 Change-Id: Ia9781ca5993b65a5e40ae864880f9d74df2df8b0 Reviewed-on: https://chromium-review.googlesource.com/1157695 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/5a3ef5c2aeab17744a59ff580ea38a96c7e1af95/appengine/findit/common/swarmbucket/swarmbucket.py [modify] https://crrev.com/5a3ef5c2aeab17744a59ff580ea38a96c7e1af95/appengine/findit/common/swarmbucket/test/swarmbucket_test.py
,
Aug 15
|
|||
►
Sign in to add a comment |
|||
Comment 1 by st...@chromium.org
, Jun 26 2018