New issue
Advanced search Search tips

Issue 856798 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jun 2018
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Make the inkdrop darker after a sink is clicked

Project Member Reported by taku...@chromium.org, Jun 26 2018 
Currently a sink button doesn't change its color right after it's clicked, so it's unclear if clicking had any effect. This is true especially on Mac where there is no ripple.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a042c8650d07e324db6c11ac1075f1cbbd70a0c

commit 2a042c8650d07e324db6c11ac1075f1cbbd70a0c
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Jun 27 01:24:24 2018

[Harmony Cast Dialog] Activate inkdrop at sink button activation

When a sink button is clicked / selected with keyboard, activate its
inkdrop to make it clearer that it's been selected. Before this change
the button color would go back to the color before click after a ripple.

Screen capture:
https://drive.google.com/open?id=1w3bToFfyQAj5vu0uakCFwT_fNkcaCHjH

Bug:  856798 
Change-Id: Id433dd7633180fcc81ebd8773e70a41b7a02b9b8
Reviewed-on: https://chromium-review.googlesource.com/1109383
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570612}
[modify] https://crrev.com/2a042c8650d07e324db6c11ac1075f1cbbd70a0c/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
[modify] https://crrev.com/2a042c8650d07e324db6c11ac1075f1cbbd70a0c/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h

Comment 2 by taku...@chromium.org, Jun 27 2018

Status: Fixed (was: Started)
►

Sign in to add a comment