History clicks in Android opens links with LINK pagetransition |
||
Issue descriptionThis is true even if the page opened clobbers the current tab which is inconsistent with other ChromeUI initiated tab opens. We should consider to use AUTO_TOP_LEVEL or AUTO_BOOKMARK for these clicks. (or something else as long as it is consistent).
,
Jun 28 2018
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf1dbf5364129a43a82f8430c53602dd74ffe646 commit cf1dbf5364129a43a82f8430c53602dd74ffe646 Author: Aaron Colwell <acolwell@google.com> Date: Thu Jun 28 17:44:32 2018 Fix PageTransition type for clicks in history page on Android. The old code marked these clicks as LINK which causes unintended consequences because they are treated as normal webpage link clicks. This change marks them as AUTO_BOOKMARK like other forms of UI generated navigations. Bug: 856788 Change-Id: Id1634e7c4f6a2286bd518db28f8b0d77c899e259 Reviewed-on: https://chromium-review.googlesource.com/1117870 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Aaron Colwell <acolwell@google.com> Cr-Commit-Position: refs/heads/master@{#571192} [modify] https://crrev.com/cf1dbf5364129a43a82f8430c53602dd74ffe646/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java [modify] https://crrev.com/cf1dbf5364129a43a82f8430c53602dd74ffe646/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java
,
Jun 28 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by yus...@chromium.org
, Jun 26 2018