Consider stopping a wider range of requests for heavy page capping |
||
Issue descriptionCurrently, asynchronous XHRs and fetch requests are not allowed to be stopped for Heavy page capping (and for other features that stop request loading). I'd like to understand if it is possible to allow these requests when the page is throttled, but to defer them when the sub-resource loading of the page is stopped entirely.
,
Jun 27 2018
Thanks kinuko! Proposed cl for technical context: https://chromium-review.googlesource.com/c/chromium/src/+/1115713
,
Jun 27 2018
Stopping everything in kStopped state sounds good to me!
,
Jun 27 2018
Yes stopping XHR and fetch (together with other regular loading requests) on scheduler::SchedulingLifecycleState::kStopped makes sense. Although would be great to keep this behind the same flag that stops other loading requests in frozen/stopped state "StopLoadingInBackground" -- currently ramping up on stable M67. Or maybe wait for this to be on by default (likely in a couple of days).
,
Jul 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f79e0abf5b37275feef6492e4cdde62333d4f69 commit 5f79e0abf5b37275feef6492e4cdde62333d4f69 Author: Ryan Sturm <ryansturm@chromium.org> Date: Sat Jul 07 00:22:52 2018 Differentiating between stopping and throttling for long polling requests This CL aims to prevent XHRs, fetch requests, etc. when the sub-resource loading on the page is disabled. Currently, these requests are unthrottleable and unstoppable, but they should just be marked as unthrottleable as stopped pages should prevent these requests. This CL also changes throttable->throttleable and throttlable->throttleable. Bug: 856776 Change-Id: Ie13aad92d45470609804427338d16da130cd89e4 Reviewed-on: https://chromium-review.googlesource.com/1115713 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573126} [modify] https://crrev.com/5f79e0abf5b37275feef6492e4cdde62333d4f69/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc [modify] https://crrev.com/5f79e0abf5b37275feef6492e4cdde62333d4f69/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h [modify] https://crrev.com/5f79e0abf5b37275feef6492e4cdde62333d4f69/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc [modify] https://crrev.com/5f79e0abf5b37275feef6492e4cdde62333d4f69/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
,
Jul 7
|
||
►
Sign in to add a comment |
||
Comment 1 by kinuko@chromium.org
, Jun 27 2018