Don't count zero-cadence frames as having been dropped. |
||
Issue descriptionchcunningham@ recently pointed out that in cases like 120fps in 60hz [1:0], 72fps in 24hz [1:0:0], etc Chrome is counting the frames we never rendered (as a matter of cadence) as dropped. This leads to massive dropped frame scores on 60Hz @ 2x playback rate content and other oddities. We shouldn't count these as dropped since dropped frames are used as performance indicators and counting these as dropped ruins the insight of dropped frames at non-1.0 playback rates (for both the site and Media Capabilities).
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81b3e819136d1ba8fc05b8e534703ad3b2f7935 commit d81b3e819136d1ba8fc05b8e534703ad3b2f7935 Author: Dale Curtis <dalecurtis@chromium.org> Date: Tue Jun 26 23:38:13 2018 Don't count zero-cadence frames as having been dropped. Without this change, things like 120fps in 60hz (60fps @ 2x rate) count every other frame as dropped since the cadence is [1:0]. Since dropped frames are used as performance indicators for various sites, we shouldn't consider these as dropped when they were fully considered and just chosen to be skipped for smoothness. BUG= 856772 TEST=YT 60fps @ 2x playback rate, updated unittests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9520504bd7cb48dfadf3f403121dcd59b739b4fe Reviewed-on: https://chromium-review.googlesource.com/1115698 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#570583} [modify] https://crrev.com/d81b3e819136d1ba8fc05b8e534703ad3b2f7935/media/filters/video_renderer_algorithm.cc [modify] https://crrev.com/d81b3e819136d1ba8fc05b8e534703ad3b2f7935/media/filters/video_renderer_algorithm_unittest.cc
,
Jun 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by dalecur...@chromium.org
, Jun 26 2018