New issue
Advanced search Search tips

Issue 856761 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security

Blocked on:
issue 857442



Sign in to add a comment

Global-buffer-overflow in webrtc::internal::AudioSendStream::RegisterCngPayloadType

Project Member Reported by ClusterFuzz, Jun 26 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6428016721526784

Fuzzer: phoglund_webrtc_peerconnection
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Global-buffer-overflow READ {*}
Crash Address: 0x7ffce84cbdc3
Crash State:
  webrtc::internal::AudioSendStream::RegisterCngPayloadType
  webrtc::internal::AudioSendStream::SetupSendCodec
  webrtc::internal::AudioSendStream::ReconfigureSendCodec
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=569669:569678

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6428016721526784

Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 

Comment 1 by aarya@google.com, Jun 27 2018

Components: Blink>WebRTC>Audio
Labels: Pri-1
Owner: kwiberg@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 27 2018

Labels: M-69 Target-69
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 27 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by ClusterFuzz, Jun 28 2018

Labels: Fuzz-Blocker ReleaseBlock-Beta
This crash occurs very frequently on windows platform and is likely preventing the fuzzer phoglund_webrtc_peerconnection from making much progress. Fixing this will allow more bugs to be found.

Marking this bug as a blocker for next Beta release.

If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
Cc: mbonadei@chromium.org
Status: Started (was: Assigned)
With help from mbonadei@ and oprypin@, I managed to build a tiny test case that appears to demonstrate that this is a compiler/linker bug: https://bugs.chromium.org/p/chromium/issues/detail?id=857442
Cc: thakis@chromium.org
Blockedon: 857442
Project Member

Comment 8 by ClusterFuzz, Jun 30 2018

ClusterFuzz has detected this issue as fixed in range 571443:571444.

Detailed report: https://clusterfuzz.com/testcase?key=6428016721526784

Fuzzer: phoglund_webrtc_peerconnection
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Global-buffer-overflow READ {*}
Crash Address: 0x7ffce84cbdc3
Crash State:
  webrtc::internal::AudioSendStream::RegisterCngPayloadType
  webrtc::internal::AudioSendStream::SetupSendCodec
  webrtc::internal::AudioSendStream::ReconfigureSendCodec
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=569669:569678
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=571443:571444

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6428016721526784

Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jun 30 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6428016721526784 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 30 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Labels: -ReleaseBlock-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 6

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment