New issue
Advanced search Search tips

Issue 856756 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::PaintLayerCompositor::UpdateIfNeeded

Project Member Reported by ClusterFuzz, Jun 26 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5363290402979840

Fuzzer: marty_html_twiddler
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::PaintLayerCompositor::UpdateIfNeeded
  blink::PaintLayerCompositor::UpdateIfNeededRecursiveInternal
  blink::PaintLayerCompositor::UpdateIfNeededRecursive
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=570319:570321

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5363290402979840

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 26 2018

Components: Blink>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 26 2018

Labels: Test-Predator-Auto-Owner
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/a9be49beca9893711aad3ffac2e00132d38c3bf8 (Optimize out work in CompositingLayerAssigner).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5976ffc34cdcacb48e9a29ad6ddb698392b6bd89

commit 5976ffc34cdcacb48e9a29ad6ddb698392b6bd89
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed Jun 27 22:55:19 2018

Mark self as needing compositing requirements on stacking change, not just ancestors.

The elements which may become stacked underneath a PaintLayer also need to be traversed.

Bug:  856756 

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iacecf53886a04ac1bb554a63162ae9aff4e6f4de
Reviewed-on: https://chromium-review.googlesource.com/1117629
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570921}
[add] https://crrev.com/5976ffc34cdcacb48e9a29ad6ddb698392b6bd89/third_party/WebKit/LayoutTests/compositing/compositing-under-parent-becomes-stacking-crash-expected.txt
[add] https://crrev.com/5976ffc34cdcacb48e9a29ad6ddb698392b6bd89/third_party/WebKit/LayoutTests/compositing/compositing-under-parent-becomes-stacking-crash.html
[modify] https://crrev.com/5976ffc34cdcacb48e9a29ad6ddb698392b6bd89/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
[modify] https://crrev.com/5976ffc34cdcacb48e9a29ad6ddb698392b6bd89/third_party/blink/renderer/core/paint/paint_layer.cc

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Jun 28 2018

ClusterFuzz has detected this issue as fixed in range 570917:570926.

Detailed report: https://clusterfuzz.com/testcase?key=5363290402979840

Fuzzer: marty_html_twiddler
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::PaintLayerCompositor::UpdateIfNeeded
  blink::PaintLayerCompositor::UpdateIfNeededRecursiveInternal
  blink::PaintLayerCompositor::UpdateIfNeededRecursive
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=570319:570321
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=570917:570926

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5363290402979840

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 28 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5363290402979840 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment