New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856742 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extensions: allow capturing of the chrome webstore page

Project Member Reported by rdevlin....@chromium.org, Jun 26 2018

Issue description

Forked from  issue 839857  - we should treat capturing the chrome webstore page similarly to other potentially-sensitive pages.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef49d508c663cb09e6587d60c64bc050e72c5c4a

commit ef49d508c663cb09e6587d60c64bc050e72c5c4a
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Jul 20 16:46:13 2018

[Extensions] Allow extensions to capture the webstore with activeTab

Normally, the Chrome Web Store is restricted from extensions. Allow
extensions to still use tabs.captureVisibleTab() if the user has
granted the extension activeTab. This is similar behavior to other
otherwise-sensitive URLs, such as chrome:-scheme URLs.

Bug:  856742 

Change-Id: Id3ea0784a86dfcfc7b2f36e40a81a1508ad2f3ee
Reviewed-on: https://chromium-review.googlesource.com/1144463
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576901}
[modify] https://crrev.com/ef49d508c663cb09e6587d60c64bc050e72c5c4a/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/ef49d508c663cb09e6587d60c64bc050e72c5c4a/chrome/common/extensions/permissions/permissions_data_unittest.cc
[modify] https://crrev.com/ef49d508c663cb09e6587d60c64bc050e72c5c4a/extensions/common/permissions/permissions_data.cc

Status: Fixed (was: Assigned)
Cc: rdevlin....@chromium.org fbouly@google.com
 Issue 881882  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3d241d95463f767e9dbbe7cd54ad00427408128

commit b3d241d95463f767e9dbbe7cd54ad00427408128
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Sep 17 19:59:58 2018

[Extensions] Clean up stale TODO

Clean up a stale TODO about allowing extensions to capture the webstore.
This was fixed in crrev.com/ef49d508c663cb09e6587d60c64bc050e72c5c4a.

Bug:  856742 
Change-Id: I5404a1f29568fcce07d1d240444a0a0d47383733
Reviewed-on: https://chromium-review.googlesource.com/1228294
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591793}
[modify] https://crrev.com/b3d241d95463f767e9dbbe7cd54ad00427408128/extensions/common/permissions/permissions_data.cc

Cc: nyerramilli@chromium.org rbasuvula@chromium.org
 Issue 838125  has been merged into this issue.

Sign in to add a comment