Permissions popup doesn't render |
|||||||||||||
Issue descriptionChrome Version: 68, 69 OS: Android What steps will reproduce the problem? (1) Give chrome permissions to microphone. (2) Go to https://immersive-web.github.io/webxr-samples/tests/permission-request.html (3) Enter VR (4) Click microphone What is the expected result? The permissions popup and grid is shown in a black environment. What happens instead? Only the controller is rendered.
,
Jun 29 2018
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/118f0d2fa00ae060a91593693ff5c59765a40a57 commit 118f0d2fa00ae060a91593693ff5c59765a40a57 Author: Aldo Culquicondor <acondor@chromium.org> Date: Tue Jul 03 17:34:37 2018 VR: keep track of dialog buffer size When entering presentation mode from 2D browsing, the content's buffer size is not set, and thus VrShellGl uses the wrong buffer size for the dialogs. Bug: 856727 Change-Id: Idf740285739e026a818b44c85fd05b34edfbd17f Reviewed-on: https://chromium-review.googlesource.com/1124864 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#572271} [modify] https://crrev.com/118f0d2fa00ae060a91593693ff5c59765a40a57/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/118f0d2fa00ae060a91593693ff5c59765a40a57/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/118f0d2fa00ae060a91593693ff5c59765a40a57/chrome/browser/android/vr/vr_shell_gl.h
,
Jul 3
,
Jul 3
,
Jul 4
,
Jul 4
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81a974ae9056552c2894e9fdf0806b7b8c8c0358 commit 81a974ae9056552c2894e9fdf0806b7b8c8c0358 Author: Aldo Culquicondor <acondor@chromium.org> Date: Thu Jul 05 14:29:56 2018 Revert "VR: keep track of dialog buffer size" This reverts commit 118f0d2fa00ae060a91593693ff5c59765a40a57. Reason for revert: This breaks the sizing of some popups in VR. Original change's description: > VR: keep track of dialog buffer size > > When entering presentation mode from 2D browsing, the content's buffer > size is not set, and thus VrShellGl uses the wrong buffer size for the > dialogs. > > Bug: 856727 > Change-Id: Idf740285739e026a818b44c85fd05b34edfbd17f > Reviewed-on: https://chromium-review.googlesource.com/1124864 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572271} TBR=mthiesse@chromium.org,acondor@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 856727 Change-Id: Icd91ff7dea7d41bfc352e25f8c7aa7095d6daedb Reviewed-on: https://chromium-review.googlesource.com/1126288 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#572787} [modify] https://crrev.com/81a974ae9056552c2894e9fdf0806b7b8c8c0358/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/81a974ae9056552c2894e9fdf0806b7b8c8c0358/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/81a974ae9056552c2894e9fdf0806b7b8c8c0358/chrome/browser/android/vr/vr_shell_gl.h
,
Jul 5
,
Jul 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10380658b5506f3251d989186f18ab904e8bb9ec commit 10380658b5506f3251d989186f18ab904e8bb9ec Author: Aldo Culquicondor <acondor@chromium.org> Date: Thu Jul 05 17:22:52 2018 VR: fix rendering of permission popups in presentation mode Bug: 856727 Change-Id: Ic1cdbe5a46f5c559713f29a217243a30347eeb89 Reviewed-on: https://chromium-review.googlesource.com/1127147 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#572820} [modify] https://crrev.com/10380658b5506f3251d989186f18ab904e8bb9ec/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/10380658b5506f3251d989186f18ab904e8bb9ec/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/10380658b5506f3251d989186f18ab904e8bb9ec/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/10380658b5506f3251d989186f18ab904e8bb9ec/chrome/browser/android/vr/vr_shell_gl.cc
,
Jul 6
,
Jul 6
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
Has this been verified in canary?
,
Jul 9
Yes
,
Jul 10
Issue 840858 has been merged into this issue.
,
Jul 10
Verified fixed in 69.0.3487.0 1. Reset Chrome permissions. Then grant them all in Settings > Apps > Chrome > Permissions 2. Go to https://immersive-web.github.io/webxr-samples/tests/permission-request.html 3. From 2D mode, click the "Enter VR" button. 4. Select the microphone icon. Verified that the infobar/pop-up appeared correctly.
,
Jul 10
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d43c450a70750db38e1c436ee029aede83ee5e7 commit 2d43c450a70750db38e1c436ee029aede83ee5e7 Author: Aldo Culquicondor <acondor@chromium.org> Date: Wed Jul 11 15:44:04 2018 VR: fix rendering of permission popups in presentation mode Bug: 856727 Change-Id: Ic1cdbe5a46f5c559713f29a217243a30347eeb89 Reviewed-on: https://chromium-review.googlesource.com/1127147 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#572820}(cherry picked from commit 10380658b5506f3251d989186f18ab904e8bb9ec) Reviewed-on: https://chromium-review.googlesource.com/1132325 Cr-Commit-Position: refs/branch-heads/3440@{#645} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/2d43c450a70750db38e1c436ee029aede83ee5e7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/2d43c450a70750db38e1c436ee029aede83ee5e7/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/2d43c450a70750db38e1c436ee029aede83ee5e7/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/2d43c450a70750db38e1c436ee029aede83ee5e7/chrome/browser/android/vr/vr_shell_gl.cc
,
Jul 16
Is this now fixed?
,
Jul 16
,
Jul 16
Pending verification in beta once a new version is released.
,
Aug 6
over to Vitali for verification on beta. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by acondor@chromium.org
, Jun 26 2018