[autofill] Flaky test in PersonalDataManagerTest |
|||
Issue description
The following test is flaky:
PersonalDataManagerTest
.GetProfileSuggestions_NoSubsetsCheckingIfTooManyProfiles
The test case ends with an expectation that probably doesn't need to be there.
The test validates that when there are more then 15 suggestions, autofill skips the expensive "dedupe" operation to merge suggestions. The last expectation validates that the first suggestion has a particular value, but the ordering of the suggestion isn't actually set/controlled by the test.
Out of the 16 suggestions, fifteen have the expected value but one has a different value, so this test can be expected to fail roughly once every 16 executions.
Looking at the flakiness dashboard bears this out.
See: https://goto.google.com/crbug-856726
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/963967d34b6a2e211320187cf0cced92fc8dc18e commit 963967d34b6a2e211320187cf0cced92fc8dc18e Author: Roger McFarlane <rogerm@chromium.org> Date: Tue Jun 26 19:18:30 2018 [autofill] Fix a flaky test Flaky test: PersonalDataManagerTest .GetProfileSuggestions_NoSubsetsCheckingIfTooManyProfiles This CL removes an errant expectation. The test validates that when there are more then 15 suggestions, autofill skips the expensive "dedupe" operation to merge suggestions. There was an extra expectation that the first suggestion has a particular value, but the ordering of the suggestion isn't actually set/controlled by the test. Out of the 16 suggestions, fifteen have the same value but one has a different value, so this test was failing roughly once every 16 runs. Bug: 856726 Change-Id: Ib17bd91d232598886e1050622b3ca8c10e856f35 Reviewed-on: https://chromium-review.googlesource.com/1115462 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570485} [modify] https://crrev.com/963967d34b6a2e211320187cf0cced92fc8dc18e/components/autofill/core/browser/personal_data_manager_unittest.cc
,
Jun 29 2018
,
Jun 29 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rogerm@chromium.org
, Jun 26 2018