New issue
Advanced search Search tips

Issue 856720 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug
Flaky-Test: TargetDomainCreateAndDeletePageTest.RunAsyncTest



Sign in to add a comment

Use-after-free in several tests in headless_browsertests

Project Member Reported by Findit, Jun 26 2018

Issue description

Comment 2 by grt@chromium.org, Jun 27 2018

Cc: jam@chromium.org altimin@chromium.org
Components: Internals>Headless
Labels: OS-Linux OS-Mac OS-Windows
Owner: skyos...@chromium.org
Status: Assigned (was: Available)
This is a use-after-free. HeadlessContentMainDelegate::RunProcess frees the HeadlessBrowserImplForTest, which destroys the net::NetLog instance in HeadlessBrowserImpl. Meanwhile, URLRequestJob::NotifyDone is run on the IO thread and tries to add to the absent NetLog.

Assigning to skyostil@, who added HeadlessContentMainDelegate.
CC jam@ who added the NetLog to the HBI.

See https://chromium-swarm.appspot.com/task?id=3e55cb4477d24e10&refresh=10&show_raw=1 for nice logs.

Comment 4 by grt@chromium.org, Jun 27 2018

Labels: -Sheriff-Chromium
Removing Sheriff-Chromium and disabling the test.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4337fd48039ae9958ebcabcefa514f6a5b1dca4b

commit 4337fd48039ae9958ebcabcefa514f6a5b1dca4b
Author: Greg Thompson <grt@chromium.org>
Date: Wed Jun 27 11:42:59 2018

Disable TargetDomainCreateAndDeletePageTest due to flakes.

BUG= 856720 
TBR=skyostil@chromium.org

Change-Id: If7de573f6c64d4f04ff08e1a82793fc3fc021ed7
Reviewed-on: https://chromium-review.googlesource.com/1116786
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570731}
[modify] https://crrev.com/4337fd48039ae9958ebcabcefa514f6a5b1dca4b/headless/lib/headless_devtools_client_browsertest.cc

Cc: -altimin@chromium.org
Owner: caseq@chromium.org
+caseq@ who now owns headless.

Comment 7 by grt@chromium.org, Jun 27 2018

FYI: this same UAF is happening in many tests. Fixing this will have a nice impact on test deflakage.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=headless_browsertests&builder=chromium.memory%3ALinux%20MSan%20Tests

Comment 8 by grt@chromium.org, Jun 27 2018

Summary: Use-after-free in several tests in headless_browsertests (was: TargetDomainCreateAndDeletePageTest.RunAsyncTest is Flaky)
Status: WontFix (was: Assigned)
Closing this as this particular test has been removed, majority of tests has been rewritten into JS, and the net/ is no longer used by headless directly.

Sign in to add a comment