Issue metadata
Sign in to add a comment
|
[MacViews] Multiple Selection doesn't work with CMD-Clicks |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3473.0 Canary OS: macOS 10.13.5 (maybe OS=All) What steps will reproduce the problem? (1) Open some tabs in a window. (2) Try to CMD-CLick some of the tabs for a multiple selection. What is the expected result? They should be multiple selected. What happens instead? Multiple selection doesn't work. This is working fine under Cocoa-Mode. (Not sure, if this is also an issue on other platforms. If yes, not sure, which key-press should be used for the selection on the other platform.) Thanks Mehmet
,
Jun 30 2018
[mac bug triage] Assigning to spqchan@ to have a look
,
Jun 30 2018
,
Jul 12
,
Aug 14
,
Aug 14
keywords: discontiguous non-adjacent selection
,
Aug 27
,
Aug 28
mac triage: to avi@ - can we fix this for M70?
,
Aug 28
Discontiguous selection works on Windows with the control key.
,
Aug 29
TabStrip::SelectTab is getting called twice for each click; once on mouse down and once on mouse-up. Not clear if that's the case on Windows.
,
Aug 29
This does happen on Windows too. This is clearly a bug.
,
Aug 29
@10/11: I think you're discovering bug 869488.
,
Aug 29
@pkasting: probably. I'll need to fix the selection change on mouse-up to implement this, so I'll rope in that bug.
,
Aug 29
@pkasting: I left a comment on that other bug, but I think I can implement this without fixing that bug.
,
Aug 29
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0361c898793cc63be2406c036bc64c3d0941be82 commit 0361c898793cc63be2406c036bc64c3d0941be82 Author: Avi Drissman <avi@chromium.org> Date: Thu Aug 30 18:01:41 2018 Use command rather than control in the tabstrip on the Mac. With Views, the control key is used for manipulating selection in the tabstrip. Given the platform convention on the Mac of using the command key for this, as well as how on the Mac a control-click triggers a contextual menu invocation, switch to a command key in those cases. BUG= 856698 Change-Id: Ic4d04f092503792da3b9bde8d6b6ed2800956697 Reviewed-on: https://chromium-review.googlesource.com/1195823 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587657} [modify] https://crrev.com/0361c898793cc63be2406c036bc64c3d0941be82/chrome/browser/ui/views/tabs/tab.cc
,
Aug 30
,
Aug 31
Able to reproduce the issue on build without fix #69.0.3473.0 using Mac OS 10.13.6 as per comment #0. Verified the fix on Mac 10.13.6 as per comment#0 on chrome version #70.0.3538.0. Attaching screen cast for reference. Observed that multiple tabs get selected by performing command+click. Adding the verified labels. Thanks...!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Jun 26 2018