New issue
Advanced search Search tips

Issue 856693 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Media Intent Handler: Enable during runtime

Project Member Reported by steimel@chromium.org, Jun 26 2018

Issue description

The MediaViewerActivity is disabled by default, and we need to selectively enable it during runtime
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a

commit c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Jul 09 22:39:36 2018

[Media Intent Handler] Selectively enable/disable MediaLauncherActivity

This CL adds a method in MediaViewerUtils to selectively enable or
disable the MediaLauncherActivity, enabling if the device is an Android
Go device and if a new HandleMediaIntents feature flag is enabled. This
new flag is enabled by default.

This CL also calls this new method when Chrome is started via the
ProcessInitializationHandler.

Bug:  856693 
Change-Id: I80f03481e399ac163a3dd10720771d6404b8d56d
Reviewed-on: https://chromium-review.googlesource.com/1121577
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573493}
[modify] https://crrev.com/c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java
[modify] https://crrev.com/c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/c63a8a7ae3ad6c5dffd5775bf38b92d70db3d05a/chrome/browser/android/chrome_feature_list.h

Status: Fixed (was: Assigned)

Sign in to add a comment