Check failed: dropdown_ignored || (log.elapsed_time_since_user_first_modified_omnibox >= log.elapsed_time_since_last_change_to_default_match) |
|||
Issue description[0626/182748.693485:FATAL:omnibox_edit_model.cc(638)] Check failed: dropdown_ignored || (log.elapsed_time_since_user_first_modified_omnibox >= log.elapsed_time_since_last_change_to_default_match). We should've got the notification that the user modified the omnibox text at same time or before the most recent time the default match changed. #3 0x0000000107e8ff38 in OmniboxEditModel::OpenMatch(AutocompleteMatch, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long) at components/omnibox/browser/omnibox_edit_model.cc:636 #4 0x0000000107eb2144 in OmniboxView::OpenMatch(AutocompleteMatch const&, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long) at components/omnibox/browser/omnibox_view.cc:95 #5 0x00000001036b5d84 in OmniboxViewIOS::OpenMatch(AutocompleteMatch const&, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long) at ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm:255 #6 0x0000000107e8e998 in OmniboxEditModel::AcceptInput(WindowOpenDisposition, bool) at components/omnibox/browser/omnibox_edit_model.cc:542 #7 0x00000001036b3150 in OmniboxViewIOS::OnAccept() at ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm:614 #8 0x00000001036b306c in ::-[AutocompleteTextFieldDelegate textFieldShouldReturn:](UITextField *) at ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm:125 Steps include some combination of visiting this URL until it turns up on autocomplete, and continually opening new tabs and typing n, p, r, . etc. https://www.npr.org/sections/thetwo-way/2018/06/01/616074574/u-s-steel-and-aluminum-tariffs-are-illegal-eu-trade-commissioner-says CCing eugenebut@ because this is related to the 11.4 strange loading bug.
,
Jun 27 2018
stkhapugin@ I wonder if we changed something here?
,
Jun 27 2018
I looked at this for a bit and I don't think we changed anything around this. Do you have repro steps?
,
Jun 27 2018
Assigning to stk@ on the meantime as Omnibox owner, please add any labels if necessary.
,
Jun 28 2018
,
Jul 9
There are steps in the bug descriptino, e.g. continually autocomplete the npr URL and open a new time. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mpear...@chromium.org
, Jun 26 2018drive-by: the failure (log.elapsed_time_since_user_first_modified_omnibox >= log.elapsed_time_since_last_change_to_default_match) likely you're not telling the omnibox when the user input is in progress correctly (ref: https://cs.chromium.org/chromium/src/components/omnibox/browser/omnibox_edit_model.cc?type=cs&q=elapsed_time_since_last_change_to_default_match&sq=package:chromium&g=0&l=1443 ) I imagine there's a race happening. It hard for me to imagine the |elapsed_time_since_last_change_to_default_match| variable being set wrong, which is why I think |elapsed_time_since_user_first_modified_omnibox| is probably wrong.) Happily, aside from getting wrong data in logs, I don't think there should be any user-visible consequence of this DCHECK failure.