New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856672 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO Dec 22 - Jan 8
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 853781


Participants' hotlists:
Audio-Service


Sign in to add a comment

Add feature flag to launch the audio service on the browser startup

Project Member Reported by olka@chromium.org, Jun 26 2018

Issue description

Audio process experiment is observing performance regressions caused by
on-the-flight audio process launch. Introducing a feature flag to
pre-launch it on the browser startup.
This will be rolled out as another AudioService experiment group, to
evaluate memory and performance impact.

The feature is disabled by default.
 

Comment 1 by olka@chromium.org, Jun 26 2018

Blocking: 853781

Comment 2 by olka@chromium.org, Jun 26 2018

Delete comment ⚐
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c0d24f28cef4117e92c146a89c97703401e866

commit c0c0d24f28cef4117e92c146a89c97703401e866
Author: Olga Sharonova <olka@chromium.org>
Date: Tue Jun 19 10:13:47 2018

Feature flag to launch the audio service on the browser startup.

Audio process experiment is observing performance regressions caused by
on-the-flight audio process launch. Introducing a feature flag to
pre-launch it on the browser startup.
This will be rolled out as another AudioService experiment group, to
evaluate memory and performance impact.

TEST=manual

Bug: 851611,853781
Change-Id: I30c1798dae07c5ce8a71243ab482ceb89d008e43
Reviewed-on: https://chromium-review.googlesource.com/1104681
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568389}
[modify] https://crrev.com/c0c0d24f28cef4117e92c146a89c97703401e866/content/browser/browser_main_loop.cc
[modify] https://crrev.com/c0c0d24f28cef4117e92c146a89c97703401e866/content/browser/browser_main_loop.h
[modify] https://crrev.com/c0c0d24f28cef4117e92c146a89c97703401e866/content/public/common/content_features.cc
[modify] https://crrev.com/c0c0d24f28cef4117e92c146a89c97703401e866/content/public/common/content_features.h
[modify] https://crrev.com/c0c0d24f28cef4117e92c146a89c97703401e866/services/audio/service.cc

Comment 3 by olka@chromium.org, Jun 26 2018

Labels: Merge-Request-68
Status: Fixed (was: Assigned)
This is landed in 69.0.3466.0 on June 19.
Requesting a merge.
The feature is behind a flag. This is a low-risk change.
Having it in M68 will allow us to refine the experiment we are running in Beta there.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 26 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge for M68. Branch:3440
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 26 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79036150d6fc5528eca0a34a8cb9e9b810f2ff05

commit 79036150d6fc5528eca0a34a8cb9e9b810f2ff05
Author: Olga Sharonova <olka@chromium.org>
Date: Tue Jun 26 17:17:35 2018

Feature flag to launch the audio service on the browser startup.

Audio process experiment is observing performance regressions caused by
on-the-flight audio process launch. Introducing a feature flag to
pre-launch it on the browser startup.
This will be rolled out as another AudioService experiment group, to
evaluate memory and performance impact.

TEST=manual

Bug: 851611,853781,  856672 
Change-Id: I30c1798dae07c5ce8a71243ab482ceb89d008e43
Reviewed-on: https://chromium-review.googlesource.com/1104681
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568389}(cherry picked from commit c0c0d24f28cef4117e92c146a89c97703401e866)
Reviewed-on: https://chromium-review.googlesource.com/1115318
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#529}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/79036150d6fc5528eca0a34a8cb9e9b810f2ff05/content/browser/browser_main_loop.cc
[modify] https://crrev.com/79036150d6fc5528eca0a34a8cb9e9b810f2ff05/content/browser/browser_main_loop.h
[modify] https://crrev.com/79036150d6fc5528eca0a34a8cb9e9b810f2ff05/content/public/common/content_features.cc
[modify] https://crrev.com/79036150d6fc5528eca0a34a8cb9e9b810f2ff05/content/public/common/content_features.h
[modify] https://crrev.com/79036150d6fc5528eca0a34a8cb9e9b810f2ff05/services/audio/service.cc

Sign in to add a comment