New issue
Advanced search Search tips

Issue 856669 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Check failed: web::GetWebClient()->IsAppSpecificURL(url_) || web_view_url == url_

Project Member Reported by justincohen@chromium.org, Jun 26 2018

Issue description

I'm seeing this all the time on various pages.  No specific steps.

[0626/181456.270298:FATAL:error_retry_state_machine.mm(112)] Check failed: web::GetWebClient()->IsAppSpecificURL(url_) || web_view_url == url_. 
(lldb) expr url_
(GURL) $1 = {
  spec_ = "https://www.washingtonpost.com/?noredirect=on"

(lldb) expr web_view_url
(const GURL) $2 = {
  spec_ = "https://www.washingtonpost.com/?noredirect=on#"
 
OK maybe this DCHECK is too fragile. Usually if webview changes URL, we call SetURL() on the navigation item and it should update the error state machine URL as well.

This DCHECK is here to guard against coding bugs that might corrupt the retry state, if the URL that finished loading in the web view is not actually the same URL tracked by the state machine. But I think it shouldn't care about URL hash. Stripping hash in this comparison can solve this problem.
Labels: M-69
Components: Mobile>iOSWeb
Components: -Mobile>WebView>Glue

Sign in to add a comment