New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856668 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

There are non-clickable areas in sync-internals traffic log.

Project Member Reported by vitaliii@chromium.org, Jun 26 2018

Issue description

It is difficult to explain to other people where to click.
We should perhaps make it all clickable or make an explicit button.
 
Labels: sync-fixit-2018q3
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/255de93b000ca811e513f67670fb6a650930202d

commit 255de93b000ca811e513f67670fb6a650930202d
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jul 09 09:33:16 2018

[Sync::Cleanup] Make traffic log entries clickable everywhere.

Previously the text was not clickable and it was difficult to explain to
others how to use it (e.g. when debugging a local issue). In this CL,
clicks on the text (except the proto itself) open the trafic log entry
too.

Bug:  856668 
Change-Id: I6a7712606d3c2880fab1736aab47509b455db8c1
Reviewed-on: https://chromium-review.googlesource.com/1128098
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573254}
[modify] https://crrev.com/255de93b000ca811e513f67670fb6a650930202d/components/sync/driver/resources/about.js
[modify] https://crrev.com/255de93b000ca811e513f67670fb6a650930202d/components/sync/driver/resources/traffic_log.js

Status: Fixed (was: Started)

Sign in to add a comment