Single tab mode lacking close button makes closing all tabs in window more frustrating |
||||||
Issue descriptionChrome Version: 69.0.3473.0 OS: Win 10 What steps will reproduce the problem? (1) Have multiple windows open (2) Have several tabs open in a window (3) Begin closing tabs by clicking the X on the tabstrib (4) Have one tab remaining What is the expected result? The ability to continue to move the pointer left as a function of the distance between tabs, such that the last tab can be closed by cliking X on the tab strip What happens instead? When only one tab is open, the only way to close is to navigate to the Window close button per the OS, rather than the per-tab button. This both reverses the direction the cursor is traveling and requires substantially greater movement.
,
Jun 26 2018
,
Jun 28 2018
I'm taking this -- when the NTB position is AFTER_TABS (as we're changing the default to), it makes sense to continue showing the tab close button right nxt to it in single tab mode (as opposed to when the NTB is LEADING/TRAILING, in which case the close button floats weirdly in space since there's no visible trailing tab divider). I'm going to make the close button presence here depend on the NTB position, which means by default in refresh, we'll have a close button for single tabs.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b78046188914eab12996154de10053b38e283f77 commit b78046188914eab12996154de10053b38e283f77 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Jun 29 20:15:13 2018 Show close buttons on inactive tabs by default, and add feature control for it. Bug: 855729 , 856667 , 846430 Change-Id: Id2c9da22f671c94ffce1995477cab0899217ea2b Reviewed-on: https://chromium-review.googlesource.com/1119538 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571607} [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/about_flags.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/flag_descriptions.h [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/ui/views/tabs/tab_close_button.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/common/chrome_features.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/common/chrome_features.h [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/tools/metrics/histograms/enums.xml
,
Jun 30 2018
,
Jul 2
Able to reproduce the issue on chrome reported version 69.0.3473.0 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #69.0.3479.0 as per the comment#0 Attaching screen cast for reference. Observed "last tab can be closed by clicking 'X' on the tab strip" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Jul 12
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rsleevi@chromium.org
, Jun 26 2018