New issue
Advanced search Search tips

Issue 856665 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[DevTools] Adding breakpoints to any line/expression should be reliable

Project Member Reported by kozy@chromium.org, Jun 26 2018

Issue description

No more dancing/trickster/inert breakpoints. All expressions should be breakpointable.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee846d80324d40d372cdc247b2cbe5b529f4e07

commit 8ee846d80324d40d372cdc247b2cbe5b529f4e07
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Jun 28 00:26:41 2018

[DevTools] allow to set breakpoint almost everywhere

Lookup for inline breakpoints only at current line.
If nothing found that try to set breakpoint at next breakable location
inside current function.

R=dgozman@chromium.org

Bug:  chromium:856665 
Change-Id: I3b5d474815adf3778430813f0a6de1d79ae35fec
Reviewed-on: https://chromium-review.googlesource.com/1114467
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570975}
[add] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-in-collected-function-expected.txt
[add] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-in-collected-function.js
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint-expected.txt
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-shifted-breakpoint.js
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint-expected.txt
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations-expected.txt
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-breakpoint-decorations.js
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations.js
[modify] https://crrev.com/8ee846d80324d40d372cdc247b2cbe5b529f4e07/third_party/blink/renderer/devtools/front_end/sources/DebuggerPlugin.js

Status: Fixed (was: Assigned)

Sign in to add a comment